Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean address input on direction switch #801

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Clean address input on direction switch #801

merged 3 commits into from
Jan 15, 2025

Conversation

kiocosta
Copy link
Contributor

@kiocosta kiocosta commented Jan 14, 2025 •
edited by michael1011
Loading

Closes #751
Closes #754

  • Address input is now cleared when switching directions.
  • Invalid addresses are not cleared when switching directions.

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025

@kiocosta is attempting to deploy a commit to the boltz Team on Vercel.

A member of the Team first needs to authorize it.

@kiocosta kiocosta force-pushed the clean-address-on-switch branch 3 times, most recently from 2f69753 to a765e9f Compare January 14, 2025 12:40
@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Jan 15, 2025 3:35pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Jan 15, 2025 3:35pm

@kiocosta kiocosta force-pushed the clean-address-on-switch branch from a765e9f to 5f5e355 Compare January 14, 2025 16:51
@kiocosta
Copy link
Contributor Author

HI, @michael1011!
I noticed the styling issues reported on the workflow. I have now fixed it and pushed the changes again. Thanks!

michael1011
michael1011 requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only solves the problem when clicking on the Reverse component. Switching directions in the asset selection does not revalidate the input in the 0-amount scenario as described in #754

2025-01-15.14-55-22.mp4

@kiocosta kiocosta force-pushed the clean-address-on-switch branch from 5f5e355 to 091c9d4 Compare January 15, 2025 15:11
@kiocosta kiocosta force-pushed the clean-address-on-switch branch from 091c9d4 to af44516 Compare January 15, 2025 15:17
@kiocosta
Copy link
Contributor Author

This only solves the problem when clicking on the Reverse component. Switching directions in the asset selection does not revalidate the input in the 0-amount scenario as described in #754

2025-01-15.14-55-22.mp4

Indeed! I have now fixed the described behaviour. The address is now cleared every time assetReceive changes. I have also added a new test case for this.

@kiocosta kiocosta requested a review from michael1011 January 15, 2025 15:23
michael1011
michael1011 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
Thank you!

@michael1011 michael1011 merged commit 3b3dc42 into BoltzExchange:main Jan 15, 2025
4 checks passed
@kilrau
Copy link
Member

kilrau commented Jan 15, 2025

Nice work! @kiocosta

If you are open to it, please reach out to [email protected], we are interested in working with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael1011 michael1011 michael1011 approved these changes

@jackstar12 jackstar12 Awaiting requested review from jackstar12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kiocosta @kilrau @michael1011