-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refund address input #796
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bullet points from issue #793:
1.+2. tACK
3. Error state saying "Enter Address" in the button is missing:
Should show "Enter address" in the button on the regular refund from local storage page too:
- CI
So we wanna tell the user in 3 different places right next to each other to enter an address? Why? |
There has to be some indicator that tells me clearly why the Refund button doesn't turn active. But I am not in fighting mood today, extracted it into another issue as I found another shitty state that we should fix too: #797 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests are failing
When you enter an address before uploading a file, the input field is reset which is why the E2E tests are failing
c9022a1
to
24b5fc1
Compare
… react to swap changes
these messages are never displayed
1796e93
to
7969ca9
Compare
closes: #793