Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refund address input #796

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Conversation

jackstar12
Copy link
Member

closes: #793

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Jan 12, 2025 1:30pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Jan 12, 2025 1:30pm

Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bullet points from issue #793:
1.+2. tACK
3. Error state saying "Enter Address" in the button is missing:
image
Should show "Enter address" in the button on the regular refund from local storage page too:
image

  • CI

@jackstar12
Copy link
Member Author

jackstar12 commented Jan 11, 2025

Error state saying "Enter Address" in the button is missing:

So we wanna tell the user in 3 different places right next to each other to enter an address? Why?
I think its perfectly fine as is - the "Refund" button is disabled because the input above is still telling you to "Enter L-BTC address"

@kilrau
Copy link
Member

kilrau commented Jan 11, 2025

Error state saying "Enter Address" in the button is missing:

So we wanna tell the user in 3 different places right next to each other to enter an address? Why? I think its perfectly fine as is - the "Refund" button is disabled because the input above is still telling you to "Enter L-BTC address"

There has to be some indicator that tells me clearly why the Refund button doesn't turn active. But I am not in fighting mood today, extracted it into another issue as I found another shitty state that we should fix too: #797

@kilrau kilrau self-requested a review January 11, 2025 16:18
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests are failing

When you enter an address before uploading a file, the input field is reset which is why the E2E tests are failing

src/components/RefundButton.tsx Outdated Show resolved Hide resolved
@michael1011 michael1011 merged commit 53b7d18 into main Jan 12, 2025
6 checks passed
@michael1011 michael1011 deleted the refactor/refund-address-input branch January 12, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refund Page Follow Up
3 participants