feat: show routing fees #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michael1011
force-pushed
the
routing-fees
branch
from
5622482 to
43d4f94
Compare
michael1011
force-pushed
the
routing-fees
branch
from
43d4f94 to
2fb6d8b
Compare
kilrau
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM
Maybe let's remove the percentage as both express the same number - redundant info. Pros know that. Probably should go with ppm as it's the more common denomination for routing fees:
A suggestion.
EDIT: maybe even as first of the three to make it stand out a bit.
michael1011
force-pushed
the
routing-fees
branch
from
2fb6d8b to
b1db75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #784
Depends on BoltzExchange/boltz-backend#774
Working demo: https://webapp-git-routing-fees-boltz.vercel.app/?ref=pro&sendAsset=BTC&receiveAsset=LN
E2E test is gonna start working once the backend PR is merged