RFC: archive: add plugin interface #485
Closed
+161
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the archive command to clean up a non local archive using a custom plugin. Therefore the plugin manifest must contain 'archiveAccessors'. Each entry should point to a class inheriting from 'BaseArchiveAccess' providing the appropriate methods to access the custom archive. Fixes BobBuildTool#340.
rhubert
force-pushed
the
archive_clean_plugin
branch
from
e0709d5
to
10d9fef
Compare
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
- Coverage 86.22% 86.15% -0.08%
==========================================
Files 46 47 +1
Lines 14175 14232 +57
==========================================
+ Hits 12223 12261 +38
- Misses 1952 1971 +19
Continue to review full report at Codecov.
|
|
I'm afraid a plug-in is not the right approach. Why not extend the archive classes to handle the garbage collection too and let the Regarding Artifactory, I hope that it does properly support WebDAV. That's what the http backend should implement... |
|
OK - I'll have a look @ WebDAV and come back... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the archive command to clean up a non local archive using a
custom plugin. Therefore the plugin manifest must contain
'archiveAccessors'. Each entry should point to a class inheriting from
'BaseArchiveAccess' providing the appropriate methods to access the
custom archive.
Fixes #340.