Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a log message when a resource is missing for block states #639

Conversation

NikitaCartes
Copy link
Member

Each block state is only logged once.
Example (1.13.2 debug world rendered with 1.21.4 resources):

[05:16:12 INFO] Start updating 1 maps (25 regions, ~25600 chunks)...
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=0]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=0]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=1]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=1]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=2]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=2]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=3]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=3]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=4]
[05:16:13 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=4]
[05:16:13 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=true,facing=north]
[05:16:13 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=false,facing=north]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=5]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=5]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=6]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=6]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=7]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=7]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=8]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=8]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=9]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=9]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=10]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=10]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=11]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=11]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=12]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=12]
[05:16:14 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=true,facing=south]
[05:16:14 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=false,facing=south]
[05:16:14 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=true,facing=west]
[05:16:14 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=false,facing=west]
[05:16:14 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=true,facing=east]
[05:16:14 DEBUG] Missing blockstate: minecraft:wall_sign[waterlogged=false,facing=east]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=13]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=13]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=14]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=14]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=true,rotation=15]
[05:16:14 DEBUG] Missing blockstate: minecraft:sign[waterlogged=false,rotation=15]

Feel free to reject this PR if it doesn't match your vision.
I have created it mainly so that it doesn't get lost in time.

@TBlueF
Copy link
Member

TBlueF commented Dec 21, 2024

So, a HashSet here is not thread-save, and it would need to be here ^^..

But anyways I think my preferred way of adding a log for this would probably be to add a simple log-line in the MissingModelRenderer.java instead, like between line 44 and 45.
It would not be guaranteed to be only logged once per block-state anymore, but i think that's fine..

Also, the message would be more "correct" if it would say something like: "No applicable renderer found for BlockState: xxx" .. but not sure if "more correct" is also "better" here 🤔

@TBlueF TBlueF closed this in 7ddb25d Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants