-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Powah Compat to the ThermoElectric Generator #4646
base: 1.16.5
Are you sure you want to change the base?
Conversation
Note: DO NOT MERGE UNTILE FORGE PR GETS MERGED |
You're not actually using a dev environment, are you? Because this doesn't compile. Which a proper IDE would have told you about. Also, the pullrequest to Forge (which also doesn't compile btw.) is not a dependency. You have not used anything of the new Forge things you PRed over there. This is gonna sound a little rude but: Do you actually know what you are doing? |
Yeah, I have a proper Forge IDE(IntelliJ), just it isn't currently working right now. So I have to adjust with Sublime Text, which has no syntax checking at all. |
So i have to rely on this compiling to check if there are any issues. Sorry about all of the commits. The last commit actually used the PR from forge, which DOES compile, if you scroll down. |
Yeah uh, fix your IDE. My guess, your Forge PR ain't gonna get merged ^^" |
It doesn't really need to, but it would definitely help. |
Also, this definitely still doesn't use the Forge PR, so I see no reason to make it a requirement for merging this. |
Ok, will remove from the first post. |
This can be merged now. |
src/main/java/blusunrize/immersiveengineering/common/IEContent.java
Outdated
Show resolved
Hide resolved
This prevents datapack from running in Safe Mode if Powah is not installed.
This PR hinges on owmii/Powah#147 getting merged. This adds dry ice and uraninite compat to the TEG.