fix: switch to SHA1 and add a try/catch block on acl inheritance hashing #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinic
approved these changes
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MD5 hashing is not FIPS compliant and in environments where compliance is enforced, .net will throw an exception. Switching to SHA1 will solve this issue. Additional try/catch for safety added.
Motivation and Context
https://specterops.atlassian.net/browse/BP-988
How Has This Been Tested?
Tested in GOAD w/ FIPS enforcement enabled
Screenshots (if appropriate):
Types of changes
Checklist: