Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TGTDelegationEnabled #168

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix TGTDelegationEnabled #168

merged 4 commits into from
Oct 15, 2024

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Oct 2, 2024

Description

Do not use CrossOrganizationNoTGTDelegation to calculate TGTDelegationEnabled.

Motivation and Context

CrossOrganizationNoTGTDelegation being false does not enable TGT delegation. That is what my testing shows. It seems like this flag became meaningless after TGT delegation was disabled by default in 2019.

How Has This Been Tested?

Locally in my lab.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

CrossOrganizationNoTGTDelegation being false does not enable TGT delegation. That is what my testing shows. It seems like this flag became meaningless after TGT delegation was disabled by default in 2019.
@JonasBK JonasBK added the bug Something isn't working label Oct 2, 2024
@JonasBK JonasBK enabled auto-merge (squash) October 2, 2024 14:41
@JonasBK JonasBK disabled auto-merge October 2, 2024 14:54
@JonasBK JonasBK enabled auto-merge (squash) October 2, 2024 14:54
@JonasBK JonasBK merged commit 37ba516 into v4 Oct 15, 2024
3 checks passed
@JonasBK JonasBK deleted the BED-4901-fix-TGTDelegationEnabled branch October 15, 2024 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants