Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BED-4820] OPTIONAL: Going a step further - ignoring error code values #162

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

definitelynotagoblin
Copy link
Contributor

Description

Motivation and Context

https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-samr/e270cd0a-5295-41be-9e89-2c3dc3a39536?redirectedfrom=MSDN

Positive values for nano-duration properties represent error codes. We can go a step further and filter these values out.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin definitelynotagoblin self-assigned this Sep 13, 2024
@definitelynotagoblin definitelynotagoblin requested a review from a team as a code owner September 13, 2024 18:43
@definitelynotagoblin definitelynotagoblin merged commit 6ec8dae into v4 Sep 16, 2024
3 checks passed
@definitelynotagoblin definitelynotagoblin deleted the anemeth/val-duration-error-codes branch September 16, 2024 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants