Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for --LDAPPassword interactively if password not specified #53

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

MJVL
Copy link

@MJVL MJVL commented Jun 26, 2023

This small PR addresses #44.

If --LDAPUsername is utilized and --LDAPPassword is not, a password can be entered dynamically.

Example:

SharpHound.exe --ldapusername myuser
2023-06-25T19:02:39.8096739-07:00|INFORMATION|This version of SharpHound is compatible with the 4.3.1 Release of BloodHound
2023-06-25T19:02:39.8799821-07:00|INFORMATION|Resolved Collection Methods: Group, LocalAdmin, Session, Trusts, ACL, Container, RDP, ObjectProps, DCOM, SPNTargets, PSRemote
2023-06-25T19:02:39.8809888-07:00|INFORMATION|Prompting for interactive LDAPPassword
LDAPPassword: *******
2023-06-25T19:02:44.4287920-07:00|INFORMATION|Initializing SharpHound at 7:02 PM on 6/25/2023

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MJVL
Copy link
Author

MJVL commented Jun 26, 2023

I have read the CLA Document and I hereby sign the CLA

@rvazarkar
Copy link
Contributor

My biggest concern here is causing hanging processes if doing this over C2

@MJVL
Copy link
Author

MJVL commented Aug 16, 2023

My biggest concern here is causing hanging processes if doing this over C2

Great point here, one I didn't consider fully. I'm not aware of a good way to check if a given run is non-interactive (but open to suggestions there).

A workaround idea I could do instead would be to have a new --LDAPInteractivePassword param instead (leave current one as is), such that if you want to enter it interactively you can, but avoiding any non-interactive session issues.

@slokie-so slokie-so added enhancement New feature or request external This pull request is from an external contributor ticketed labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external This pull request is from an external contributor ticketed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants