-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Username autocompletion #82
base: master
Are you sure you want to change the base?
Conversation
This doesn't actually query the cache yet. For that, we need an appropriate UI. It does, however, fill it at opportune times: whenever messages come in, and when you query.
…hucker/Gitter into features/username-autocomplete
A very early version of the UI is now here. The positioning is, too, but doesn't seem to actually work yet. |
I've removed draft status because this is way beyond proof of concept now. Remaining issues before this should be merged:
Remaining issues that I don't think should block a merge:
|
For the user list, I would personally be happy to let it pop up where you have it - the horizontal doesn't matter too much, but if you want to try and position it, I found this that seems to work https://medium.com/@jh3y/how-to-where-s-the-caret-getting-the-xy-position-of-the-caret-a24ba372990a |
Yeah, the offscreen div approach is one I evaluated. I'll consider it. |
Suggest users when typing
@
followed by part of a user name or display name.Multiple aspects required:
we need a UI like Gitter's own, or like in https://github.com/Blazored/Typeahead/ (but we can't outright use Typeahead, I believe, because it seems to always require a drop-down rather than being invoked inline from the message input box). Stuff like arrow up/down to select someone, etc.
we need JS interop to get the cursor position (I think)
we need the API-side search. Unlike Gitter's own client, this PR takes advantage of Cache room users? #75 so results are more comprehensive.