Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solomon2022 #690

Closed
wants to merge 11 commits into from
Closed

Solomon2022 #690

wants to merge 11 commits into from

Conversation

sologebre
Copy link
Contributor

No description provided.

Copy link
Contributor

@thea-m thea-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Solomon! Technically everything is fine, but it would be extremely useful if you could possibly elaborate this record a little bit.

<teiHeader>
<fileDesc>
<titleStmt>
<title xml:lang="gez" xml:id="t1">Maṣḥafa tārik</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the title in fidal?

</teiHeader>
<text>
<body>
<div type="bibliography"/><!---->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add at least the incipit and explicit, and possibly an abstract briefly summarising the content. And in the case of this lengthy work, maybe some subdivision into the major parts (if they can be identified) might also be useful. The normal users of BM will not have access to the manuscript description for a long time, so any information that disambiguates this work will be very useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Dorothea!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bibliography might be of help, with the tag of a specific reference taken from the zotero database.
For any suggestion, you can look at the guidelines (https://betamasaheft.eu/Guidelines/?id=works) or at some of the latest work records in the database.

@thea-m
Copy link
Contributor

thea-m commented Feb 10, 2022

Copy link
Contributor

@thea-m thea-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for the late reaction. These seem really interesting!

@@ -49,7 +54,30 @@ type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
</teiHeader>
<text>
<body>
<div type="bibliography"/><!---->
<div type="edition">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there are a few small problems here with the nesting of textparts. Do I understand it correctly, that the text is divided in the parts "Genealogyofkings", "GenealogyofMary", "GenealogyofEthiopiankings", and "LIT6568YanagastatKebr", and that you give the incipit for each of these textparts? If so, each of these textparts should be their own <div type="textpart"> and then contain a further <div type="textpart" subtype="incipit"> in which the incipit should be encoded. But maybe I misunderstood.

<profileDesc>
<creation/>
<abstract>
<p/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that a small description in the abstract, or some indication in the edition on the textparts would be very helpful. For instance, I would wonder immediately whether this work is a translation of Kəbra nagaśt or another work?

@eu-genia
Copy link
Contributor

eu-genia commented Feb 7, 2023

it would be nice if work records when created are also merged for everyone to know that they are there, could you please finalize the PR? thank you!

@thea-m
Copy link
Contributor

thea-m commented Feb 7, 2023

I will continue to work on this.

@thea-m
Copy link
Contributor

thea-m commented Jan 24, 2024

I have continued to look into this, and decided that a detailed description of all subparts - difficult to distinguish in the manuscript - would take too much time at this point. It might be an interesting topic for further research. For the purposes of cataloguing, I would propose the minimalist description present now. (I have kept the subparts that had already been started, because they are not wrong, but commented them out)

@eu-genia
Copy link
Contributor

@thea-m can you maybe fix the conflicts and merge this? thank you

@thea-m
Copy link
Contributor

thea-m commented Oct 29, 2024

If it's alright, I will deal with this when I come back in December :)

@thea-m thea-m mentioned this pull request Dec 3, 2024
@thea-m
Copy link
Contributor

thea-m commented Dec 3, 2024

#1342

@thea-m thea-m closed this Dec 3, 2024
@thea-m thea-m deleted the Solomon2022 branch December 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants