-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lit6916 gadla eup #1048
Merged
Merged
Lit6916 gadla eup #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thea-m
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, very nice! one minimal question
new/LIT6916GadlaEup.xml
Outdated
<titleStmt> | ||
<title xml:lang="en" xml:id="t1">The life of St Euphrasia of Constantinople</title> | ||
<title xml:lang="gez" xml:id="n2">ሥነ ፡ ሕይወት፡ ወምግባር፡ ዘቅድስት፡ ወብፅዕት፡ ድንግል፡ ኤዎጰራክስያ፡</title> | ||
<title xml:lang="gez" type="normalized" corresp="#n2">Śǝna ḥǝywat wa-mǝgbār za-qǝddǝst wa-bǝḍʿǝt dǝngǝl ʾEwoṗarāksǝyā</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say bǝḍǝʿt
Of course!
pt., 2 lut 2024 o 18:38 thea-m ***@***.***> napisał(a):
… ***@***.**** requested changes on this pull request.
Thank you, very nice! one minimal question
------------------------------
In new/LIT6916GadlaEup.xml
<#1048 (comment)>:
> @@ -0,0 +1,63 @@
+<?xml-model href="https://raw.githubusercontent.com/BetaMasaheft/schema/master/tei-betamesaheft.rng"
+schematypens="http://relaxng.org/ns/structure/1.0"?><?xml-model href="https://raw.githubusercontent.com/BetaMasaheft/schema/master/tei-betamesaheft.rng"
+type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
+<TEI xmlns="http://www.tei-c.org/ns/1.0" xml:id="LIT6916GadlaEup" xml:lang="en" type="work">
+ <teiHeader>
+ <fileDesc>
+ <titleStmt>
+ <title xml:lang="en" xml:id="t1">The life of St Euphrasia of Constantinople</title>
+ <title xml:lang="gez" xml:id="n2">ሥነ ፡ ሕይወት፡ ወምግባር፡ ዘቅድስት፡ ወብፅዕት፡ ድንግል፡ ኤዎጰራክስያ፡</title>
+ <title xml:lang="gez" type="normalized" corresp="#n2">Śǝna ḥǝywat wa-mǝgbār za-qǝddǝst wa-bǝḍʿǝt dǝngǝl ʾEwoṗarāksǝyā</title>
I would say bǝḍǝʿt
—
Reply to this email directly, view it on GitHub
<#1048 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO62KJQJ6TMM6QKZFFJVJYTYRUQAZAVCNFSM6AAAAABCR4S55KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJZHE3DENJVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
thea-m
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BetaMasaheft/Documentation#2472
I would suggest to keep the English title as the main title, the Ge'ez one is not very 'title-like'...