-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 09 25 jk prs in uub q1524o #1005
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, very nice!
new/PRS14574GabraLeul.xml
Outdated
<profileDesc> | ||
<creation/> | ||
<abstract> | ||
<p>Gabra Lǝʿul Tǝrfe attended the boyschool of the Swedish Mission in the 1890s, spent a year in Italy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boys' school?
new/PRS14574GabraLeul.xml
Outdated
<creation/> | ||
<abstract> | ||
<p>Gabra Lǝʿul Tǝrfe attended the boyschool of the Swedish Mission in the 1890s, spent a year in Italy, | ||
and later returned as an evangelist in <date from="1901" to="1902">1901–1902</date> and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missionary? here and elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in the Protestant contexts I know, I think "missionary" and "evangelist" are not exactly synonyms. Maybe I add "Protestant" to make it clear that he's not one of the Four.
<persName xml:lang="gez" type="normalized" corresp="#n1">Gabra Lǝʿul Tǝrfe</persName> | ||
<floruit notBefore="1870" notAfter="1950">19th-20th century</floruit> | ||
<faith type="Protestantism"/> | ||
<occupation type="ecclesiastic"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to delete the empty elements for a cleaner record
new/PRS14575KidanaMaryam.xml
Outdated
<person sex="1"> | ||
<persName xml:lang="gez" xml:id="n1">ኪዳነ፡ ማርያም፡</persName> | ||
<persName xml:lang="gez" type="normalized" corresp="#n1">Kidāna Māryām</persName> | ||
<t:faith xmlns:t="http://www.tei-c.org/ns/1.0" type="EOTC Protestantism"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superfluous t: etc has to be deleted :(
new/PRS14574GabraLeul.xml
Outdated
<profileDesc> | ||
<creation/> | ||
<abstract> | ||
<p>Gabra Lǝʿul Tǝrfe attended the boyschool of the Swedish Mission in the 1890s, spent a year in Italy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until this issue is resolved, I don't think we should continue to use abstract for person records BetaMasaheft/Documentation#2732
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema does not allow <bibl>
elements in <floruit>
, it seems, so the usual solution does not work here. If we are going to use <floruit>
for bibliographies, it would be good if it allowed <bibl>
new/PRS14576AndersSvensson.xml
Outdated
<body> | ||
<listPerson> | ||
<person sameAs="Q115903389" sex="1"> | ||
<persName xml:lang="gez" xml:id="n1">Anders Svensson</persName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sv, forename and last name could be split
new/PRS14574GabraLeul.xml
Outdated
<date from="1910" to="1924">1910–1924</date>. The major part of the contents of the | ||
manuscript <ref type="mss" corresp="UppQ1524o"/> is said to derive from a text collection | ||
called "Gabra Lǝʿul's collection | ||
of <foreign xml:lang="gez">qəne</foreign>". It is possible that he is the author of some or all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"he is either the author or the collector"
I remember, that we discussed the authorship or not-authorship in a previous pull request.
new/PRS14574GabraLeul.xml
Outdated
<person sex="1"> | ||
<persName xml:lang="gez" xml:id="n1">ገብረ፡ ልዑል፡ ትርፌ፡</persName> | ||
<persName xml:lang="gez" type="normalized" corresp="#n1">Gabra Lǝʿul Tǝrfe</persName> | ||
<floruit notBefore="1870" notAfter="1950">19th-20th century</floruit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the floruit is known more precisely, it is useful to express it also verbally: Either: "1870-1950" or "End of the 19th century and first half of the 20th century"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete line 79 and update line 84. One floruit is enough
new/PRS14575KidanaMaryam.xml
Outdated
<persName xml:lang="gez" type="normalized" corresp="#n1">Kidāna Māryām</persName> | ||
<t:faith xmlns:t="http://www.tei-c.org/ns/1.0" type="EOTC Protestantism"/> | ||
<occupation type="ecclesiastic"/> | ||
<floruit notBefore="1850" notAfter="1950">1850-1950</floruit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is an estimation, I think it is more useful to print: "Second half of 19th and first half of 20th century".
new/PRS14576AndersSvensson.xml
Outdated
<p>Anders Svensson, born in Nävlinge socken in <date when="1849">1849</date>, was ordained a | ||
priest in Lund in <date when="1874">1874</date>, and became a missionary for | ||
SEM in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside | ||
Imkullo. From 1885 to 1897, he was the head of the school, which from 1890 was located in Zazega. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create LOC IDs (if needed) and mark up Imkullo and Zazega?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IDs are there and should be placed in residence
new/PRS14576AndersSvensson.xml
Outdated
<abstract> | ||
<p>Anders Svensson, born in Nävlinge socken in <date when="1849">1849</date>, was ordained a | ||
priest in Lund in <date when="1874">1874</date>, and became a missionary for | ||
SEM in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write acronym SEM in full in the first place.
new/PRS14576AndersSvensson.xml
Outdated
<body> | ||
<listPerson> | ||
<person sameAs="Q115903389" sex="1"> | ||
<persName xml:lang="gez" xml:id="n1">Anders Svensson</persName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no gez,
<forename></forename><surname></surname>
new/PRS14576AndersSvensson.xml
Outdated
<listPerson> | ||
<person sameAs="Q115903389" sex="1"> | ||
<persName xml:lang="gez" xml:id="n1">Anders Svensson</persName> | ||
<persName xml:lang="gez" type="normalized" corresp="#n1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no gez normalized. Delete line 61.
new/PRS14576AndersSvensson.xml
Outdated
<faith type="Protestantism"/> | ||
<occupation type="ecclesiastic"/> | ||
<nationality type="Sweden"/> | ||
<birth when="1894-04-07">1849</birth> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Express month and day of birth and death also verbally.
new/PRS14579WaldaGabreel.xml
Outdated
</availability> | ||
</publicationStmt> | ||
<sourceDesc> | ||
<p><roleName type="title">Daǧǧāčč</roleName>Walda Gabrəʾel is the author of a <foreign xml:lang="gez">qəne</foreign> poem attested in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space between <roleName type="title">Daǧǧāčč</roleName>
and Walda Gabrəʾel
new/PRS14579WaldaGabreel.xml
Outdated
<persName xml:lang="gez" xml:id="n1">ወልደ፡ ገብርኤል፡</persName> | ||
<persName xml:lang="gez" type="normalized" corresp="#n1">Walda Gabrəʾel</persName> | ||
<occupation type="literary"/> | ||
<floruit notBefore="1870" notAfter="1950">1870-1950</floruit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either like this or more inprecise: "Probably 1870-1950" or "End of 19th and first half of 20th century"
new/PRS14576AndersSvensson.xml
Outdated
As the chairman of the missionary conference (Swed. <foreign xml:lang="sv">missionskonferens</foreign>) | ||
from 1886 to 1913, he travelled through the entire area where the SEM was active, ordaining priests and | ||
consecrating churches and graveyards. | ||
He is buried in Zazega. According to <bibl><ptr target="bm:Kahassai2023"/></bibl>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing in bibliography; the bibliography of a record, just like of an article in a journal, should list all titles referred to.
if you have a title in the bibliography you do not need bibl elements, you can use a ref to point to the xml:id of the bibliographic record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing the abstract and moving the information under person as per TEI guidelines
<listPerson>
<person sameAs="Q115903389" sex="1">
<persName xml:lang="sv" xml:id="n1"><forename>Anders</forename> <surname>Svensson</surname></persName>
<persName xml:lang="ti" xml:id="n2" cert="unknown"><roleName type="office">ቀሺ</roleName> ሜንሶን
<note>The name is attested in <ref type="mss" corresp="UppQ1524o"><locus target="#5r"/></ref>; identified with Svensson by <ref target="#kahsai">Girmai Kahassai 2023</ref></note></persName>
<persName xml:lang="ti" corresp="#n2" type="normalized"><roleName type="office">Qašši</roleName> Menson</persName>
<faith type="Protestantism"/>
<occupation type="ecclesiastic"/>
<nationality type="Sweden"/>
<birth when="1894-04-07">7 April 1849, Nävlinge socken</birth>
<floruit>He was ordained a
priest in Lund in <date when="1874">1874</date>, and became a missionary for
Swedish Evangelical Mission in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside
<placeName ref="LOC2852Emkull"></placeName>. From 1885 to 1897, he was the head of the school, which from 1890 was located in <placeName ref="LOC5393Saazza"></placeName>.
As the chairman of the missionary conference (Swed. <foreign xml:lang="sv">missionskonferens</foreign>)
from 1886 to 1913, he travelled through the entire area where the SEM was active, ordaining priests and
consecrating churches and graveyards.
He is buried in <placeName ref="LOC5393Saazza"></placeName>.</floruit>
<death when="1928-06-04">4 June 1928, <placeName ref="LOC5393Saazza"></placeName></death>
</person>
<listRelation>
<relation name="lawd:hasAttestation" active="PRS14576AndersSvensson" passive="UppQ1524o"/>
<relation name="snap:ProfessionalRelationship" active="PRS14576AndersSvensson" passive="PRS14574GabraLeul"></relation>
</listRelation>
</listPerson>
<listBibl type="secondary">
<bibl>
<ptr target="bm:Lundstroem2011Kenisha"/>
<citedRange unit="page">481</citedRange>
</bibl>
<bibl>
<ptr target="bm:Julen1954Svensson"/>
</bibl>
<bibl xml:id="kahsai"><ptr target="bm:Kahassai2023"/></bibl>
</listBibl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for other records
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this informative suggestion! Very useful!
new/PRS14576AndersSvensson.xml
Outdated
<p>Anders Svensson, born in Nävlinge socken in <date when="1849">1849</date>, was ordained a | ||
priest in Lund in <date when="1874">1874</date>, and became a missionary for | ||
Swedish Evangelical Mission in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside | ||
Imkullo. From 1885 to 1897, he was the head of the school, which from 1890 was located in Zazega. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOC2852Emkull
new/PRS14576AndersSvensson.xml
Outdated
<p>Anders Svensson, born in Nävlinge socken in <date when="1849">1849</date>, was ordained a | ||
priest in Lund in <date when="1874">1874</date>, and became a missionary for | ||
Swedish Evangelical Mission in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside | ||
Imkullo. From 1885 to 1897, he was the head of the school, which from 1890 was located in Zazega. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume LOC5393Saazza
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably yes, thank you!
new/PRS14576AndersSvensson.xml
Outdated
<p>Anders Svensson, born in Nävlinge socken in <date when="1849">1849</date>, was ordained a | ||
priest in Lund in <date when="1874">1874</date>, and became a missionary for | ||
SEM in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside | ||
Imkullo. From 1885 to 1897, he was the head of the school, which from 1890 was located in Zazega. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IDs are there and should be placed in residence
manuscript <ref type="mss" corresp="UppQ1524o"/> is said to derive from a text collection | ||
called "Gabra Lǝʿul's collection | ||
of <foreign xml:lang="gez">qəne</foreign>". Presumably, he is either the author or the collector of (some or all | ||
of) these <foreign xml:lang="gez">qəne</foreign>s.</floruit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The information on the possible authorship of qene poems is probably better to be encoded in
<occupation type="literary"><occupation>
Evangelicals and was active as an evangelist in | ||
<placeName ref="LOC4012Karnas"/> from <date when="1895"/> to <date when="1910"/>. | ||
From <date when="1911"/> to <date when="1912"/>, he was active in <placeName ref="LOC6569Tegray"/>. | ||
He is possibly the author of an eulogistic composition attested in <ref type="mss" corresp="UppQ1524o"/>.</floruit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better in <occupation type="literary"><occupation>
.
<floruit notBefore="1850" notAfter="1950">Second half of 19th and first half of 20th century.</floruit> | ||
<floruit notBefore="1850" notAfter="1950">Second half of 19th and first half of 20th century. | ||
According to <ref target="#Lundstroem2011Kenisha"/>, Kidāna Māryām was originally an | ||
Orthodox <foreign xml:lang="gez">dabtarā</foreign>. As of <date when="1895"/>, he supported the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better in <occupation type="ecclesiastic"><occupation>
Orthodox <foreign xml:lang="gez">dabtarā</foreign>. As of <date when="1895"/>, he supported the | ||
Evangelicals and was active as an evangelist in | ||
<placeName ref="LOC4012Karnas"/> from <date when="1895"/> to <date when="1910"/>. | ||
From <date when="1911"/> to <date when="1912"/>, he was active in <placeName ref="LOC6569Tegray"/>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better in <residence></residence>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not optimal to have to divide these things up into different categories…
was active as an evangelist in <placeName ref="LOC4012Karnas"/>
could be both occupation
and residence
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you prefer. It might be better for those, who look up things according to occupation or residence etc.
new/PRS14576AndersSvensson.xml
Outdated
Swedish Evangelical Mission in Eritrea in <date when="1877">1877</date>. He was a teacher at the school outside | ||
<ref type="place" corresp="LOC2852Emkull">Imkullo</ref>. From 1885 to 1897, he was the head of the school, | ||
which from 1890 was located in <ref type="place" corresp="LOC5393Saazza">Zazega</ref>. | ||
As the chairman of the missionary conference (Swed. <foreign xml:lang="sv">missionskonferens</foreign>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think you need "Swed." as you have the xml:lang
from 1886 to 1913, he travelled through the entire area where the SEM was active, ordaining priests and | ||
consecrating churches and graveyards. | ||
He is buried in Zazega. According to <ref target="#Kahassai2023"></ref>, | ||
he was locally known as <foreign xml:lang="ti"><roleName type="office">ቀሺ</roleName> ሜንሶን</foreign> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you decided again putting this as n2? OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that you had suggested it, but I added it now. Thank you!
Persons connected to the qene collection of Kolmodin (http://www.alvin-portal.org/alvin/view.jsf?pid=alvin-record%3A280997&dswid=6173). If anyone would like to, I would appreciate a second pair of eyes at the "relations" between the persons and work files, if they seem reasonable.