Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 build(expath): make deps explicit #21

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Draft

🔧 build(expath): make deps explicit #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@

.DS_Store

xars/*/
7 changes: 6 additions & 1 deletion db/apps/BetMas/expath-pkg.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<package xmlns="http://expath.org/ns/pkg" name="https://www.betamasaheft.uni-hamburg.de/BetMas" abbrev="BetaMasaheft" version="5.0" spec="1.0">
<title>Beta maṣāḥǝft: Manuscripts of Ethiopia and Eritrea</title>
<dependency package="http://exist-db.org/apps/shared"/>
<dependency package="http://exist-db.org/apps/shared" semver-min="0.9.1"/>
<dependency package="https://betamasaheft.eu/betmasweb/" semver-min="0.1"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why BetMas - as the legacy application - depends on its successor betmasweb?
Will this not introduce a circular dependency, when the hidden dependency in betmasweb on betmas is declared?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it will, so before we actually deploy anything we need to resolve these properly. But my goal for now is to declare the current status, warts n all .

<dependency package="http://betamasaheft.aai.uni-hamburg.de/gez-en/" semver-min="2.6"/>
<dependency package="http://betamasaheft.eu/guidelines" semver-min="0.1"/>
<dependency package="http://betamasaheft.aai.uni-hamburg.de/parser/" semver-min="0.5"/>
<dependency processor="http://exist-db.org" semver-min="5.2.0"/>
</package>