add static demo option #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenDMyers
requested changes
Oct 3, 2022
There was a problem hiding this comment.
This looks great, and provides such a nice local experience. Thanks for this contribution, @NickyMeuleman! I've just got one little request for documentation, but then I'll be happy to merge this in!
BenDMyers
approved these changes
Oct 3, 2022
|
Great work, @NickyMeuleman! Merging in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #66 and #69
Untabled the idea after a long break.
This PR adds a way to get a static DEMO page.
Useful when developing a theme so the message you are styling doesn't scroll off the page by new ones being added.
Much simpler implementation this time around, no special parameter handling as one extra possibility for a query parameter doesn't require added complexity there.
When
DEMO=staticis passed, the demo page generates the number of messages specified by theshowLatestMessages(always present as it's set to 100 if not explicitly specified) option immediately and does not add more.Demo of workflow:
URL used:
http://localhost:8080/c/showmychat?theme=advent-of-code&showLatestMessages=10&DEMO=staticchanging the color of a mentioned user from red to blue