Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option processing for label-cutoff to cluster.py #13

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

rjoshi44
Copy link

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link

codecov bot commented Jan 15, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@orbeckst orbeckst requested a review from rsexton2 January 15, 2025 17:00
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Please also add yourself to AUTHORS.md.

@rsexton2 are you starting a CHANGELOG? — if so, please provide guidance on how you want @rjoshi44 to add an entry.

(I am only commenting, I am leaving it to @rsexton2 to do a request changes/approve review as he's in charge of the project.)

@rsexton2 rsexton2 merged commit 42b7f29 into Becksteinlab:main Jan 16, 2025
10 checks passed
@rsexton2
Copy link
Collaborator

Thank you @rjoshi44, feel free to add more of these as you encounter them.
@orbeckst I'll start a changelog soon but this looks good for now.

Copy link
Collaborator

@rsexton2 rsexton2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, there are likely many of these so feel free to add more as you encounter them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants