Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added spline interpolation #232

Closed
wants to merge 1 commit into from
Closed

added spline interpolation #232

wants to merge 1 commit into from

Conversation

Suvrat1629
Copy link

#228 added spline interpolation

@Suvrat1629
Copy link
Author

@GrazianoCapelli updates?

@GrazianoCapelli
Copy link
Member

Hello @Suvrat1629
first of all thanks for your pull request.
I apologize for the delay, yesterday I was very busy and I had no spare time to answer and to check your commit.

Now I checked it, and I found that the app doesn't run because the cubicSplineInterpolation method is not found.
Furthermore, in your code the function that returns the EGM correction has been renamed, thus the app cannot call the method anymore. As last consideration I cannot find the 3x3 matrix that should be used for interpolation.
Did you check it?

Unfortunately I cannot accept your commit as is.
Please run and test your code (and the app) before to pull it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants