Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shfmt and shellcheck for a few more files #2273

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

seefood
Copy link
Contributor

@seefood seefood commented Nov 19, 2024

Description

picked a few completions and plugins at random and cleaned them up with shellcheck and shfmt

How Has This Been Tested?

passed to the CI after pre-commit was happy

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood requested a review from gaelicWizard November 19, 2024 21:45
@seefood seefood merged commit fc83d4c into Bash-it:master Nov 20, 2024
4 of 6 checks passed
@seefood seefood deleted the ira/shellcheck_1 branch November 20, 2024 12:02
@cornfeedhobo
Copy link
Member

@seefood Would you like some help with reviews? I'm concerned about these failing tests and how much code is getting merged and self-reviewed right now.

@seefood
Copy link
Contributor Author

seefood commented Nov 21, 2024

@seefood Would you like some help with reviews? I'm concerned about these failing tests and how much code is getting merged and self-reviewed right now.

I would love some. Noah gave me maintainer rights to release some of the pressure, and I merged the easy stuff that was stuck, but most of what remans are the trickier stuff that's got some bitrot, and some of it needs manual merges, while others are maybe no longer relevant.

the issue with BATS complaining about too few tests running - I have no idea why iot happens yet, I have not dived into that yet.

@cornfeedhobo
Copy link
Member

My memory with BATS is fuzzy, but I think when BATS complains about too few tests running, it means the test environment is broken and/or a test has failed.

Would you like to open a PR to start fixing the tests before merging much more stuff?

@seefood
Copy link
Contributor Author

seefood commented Nov 28, 2024

@cornfeedhobo I never used bats and won't have time to get into it before next year, so if you know how t fix it, be my guest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants