Added proper error handling on getResult of location settings

geolocator_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.6.2
+
+* Fixes crash when `RuntimeExecutionException` is encountered in `getResult` in `checkLocationSettings`.
+
 ## 4.6.1
 
 * Fixes a bug where the plugin throws an exception while requesting locations updates with coarse location permission only.

geolocator_android/android/src/main/java/com/baseflow/geolocator/errors/ErrorCodes.java

@@ -4,6 +4,7 @@ public enum ErrorCodes {
   activityMissing,
   errorWhileAcquiringPosition,
   locationServicesDisabled,
+  locationServicesFailed,
   permissionDefinitionsNotFound,
   permissionDenied,
   permissionRequestInProgress;
@@ -16,6 +17,8 @@ public String toString() {
         return "ERROR_WHILE_ACQUIRING_POSITION";
       case locationServicesDisabled:
         return "LOCATION_SERVICES_DISABLED";
+      case locationServicesFailed:
+        return "LOCATION_SERVICES_FAILED";
       case permissionDefinitionsNotFound:
         return "PERMISSION_DEFINITIONS_NOT_FOUND";
       case permissionDenied:
@@ -35,6 +38,8 @@ public String toDescription() {
         return "An unexpected error occurred while trying to acquire the device's position.";
       case locationServicesDisabled:
         return "Location services are disabled. To receive location updates the location services should be enabled.";
+      case locationServicesFailed:
+        return "Location services failed.";
       case permissionDefinitionsNotFound:
         return "No location permissions are defined in the manifest. Make sure at least ACCESS_FINE_LOCATION or ACCESS_COARSE_LOCATION are defined in the manifest.";
       case permissionDenied:

geolocator_android/android/src/main/java/com/baseflow/geolocator/location/FusedLocationClient.java

@@ -29,6 +29,7 @@
 import com.google.android.gms.location.LocationSettingsStatusCodes;
 import com.google.android.gms.location.Priority;
 import com.google.android.gms.location.SettingsClient;
+import com.google.android.gms.tasks.RuntimeExecutionException;
 
 import java.security.SecureRandom;
 
@@ -167,19 +168,27 @@ public void isLocationServiceEnabled(LocationServiceListener listener) {
             (response) -> {
               if (!response.isSuccessful()) {
                 listener.onLocationServiceError(ErrorCodes.locationServicesDisabled);
+                return;
               }
 
-              LocationSettingsResponse lsr = response.getResult();
-              if (lsr != null) {
-                LocationSettingsStates settingsStates = lsr.getLocationSettingsStates();
-                boolean isGpsUsable = settingsStates != null && settingsStates.isGpsUsable();
-                boolean isNetworkUsable =
-                    settingsStates != null && settingsStates.isNetworkLocationUsable();
-                listener.onLocationServiceResult(isGpsUsable || isNetworkUsable);
-              } else {
-                listener.onLocationServiceError(ErrorCodes.locationServicesDisabled);
+              try {
+                LocationSettingsResponse lsr = response.getResult();
+                if (lsr != null) {
+                    LocationSettingsStates settingsStates = lsr.getLocationSettingsStates();
+                    boolean isGpsUsable = settingsStates != null && settingsStates.isGpsUsable();
+                    boolean isNetworkUsable =
+                        settingsStates != null && settingsStates.isNetworkLocationUsable();
+                    listener.onLocationServiceResult(isGpsUsable || isNetworkUsable);
+                } else {
+                    listener.onLocationServiceError(ErrorCodes.locationServicesDisabled);
+                }
+              } catch (RuntimeExecutionException e) {
+                listener.onLocationServiceError(ErrorCodes.locationServicesFailed);
               }
-            });
+            })
+        .addOnFailureListener((e) -> {
+            listener.onLocationServiceError(ErrorCodes.locationServicesFailed);
+        });
   }
 
   @SuppressLint("MissingPermission")