[Android] Enhancement-561/satelliteCount and satellitesUsedInFix #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # geolocator_android/CHANGELOG.md
TimHoogstrate
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
===========================================
+ Coverage 94.73% 100.00% +5.26%
===========================================
Files 4 13 +9
Lines 114 244 +130
===========================================
+ Hits 108 244 +136
+ Misses 6 0 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mvanbeusekom
requested changes
Nov 2, 2023
geolocator_android/android/src/main/java/com/baseflow/geolocator/location/LocationMapper.java
Outdated
Show resolved
Hide resolved
geolocator_android/android/src/main/java/com/baseflow/geolocator/location/NmeaClient.java
Outdated
Show resolved
Hide resolved
…or/location/NmeaClient.java Co-authored-by: Maurits van Beusekom <[email protected]>
Co-authored-by: Maurits van Beusekom <[email protected]>
Co-authored-by: Maurits van Beusekom <[email protected]>
Co-authored-by: Maurits van Beusekom <[email protected]>
2 tasks
# Conflicts: # geolocator_android/CHANGELOG.md # geolocator_android/pubspec.yaml
|
@mvanbeusekom I don't think this was tested at all before merging. The AndroidPosition class zeroes out all the values and the the equals method is flawed checking only the new properties |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds satelliteCount and satellitesUsedInFix from the GNSS callback in Android.
It partly resolves #561.
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.