-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated libraries #4
base: master
Are you sure you want to change the base?
Conversation
It need to target Android 8 to work. Did you check if the samples are still working? |
Yeah samples still worked as before.. Only horizontal scroll works, vertical still no good |
Did you check the code to see if anything causes this bug? |
Yeah, I tried to find something, but haven't found anything... still trying to figure it out, but since it's your code, maybe you could find it faster than me |
@martijn00 Have you managed to find the bug?? |
@martijn00 I noticed that When I try to drag an item I get notified by this message "Start drag has been called but swiping is not enabled". But also I noticed that in RecyclerListAdapter class the overriden OnItemMove method is never called! |
I finally made it work... In SimpleItemTouchHelperCallback class I made variable swipeEnabled = false. Now I can drag and drop normally! Of course in my case I don't need swiping so maybe you could update your nuget with possibility to turn on/off swiping or dragging?? |
Can you make a fix to add that? |
Sorry.. after I posted last comment I saw that you actually can turn on/off drag or swipe.. so it's all good, but the problem is that when both are on you can't drag.. |
Updated libraries, solution builds properly