1.3.5

BartmanAbyss · May 16, 2022 · 0b05fa2 · 0b05fa2
1 parent 5f0553d
commit 0b05fa2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ All notable changes to the "amiga-debug" extension will be documented in this fi
 
 ## 1.3.5
 - use VSCode built-in memory viewer (click the binary icon beside a variable in the debug view)
+- fix crash in WinUAE when requesting a memory dump
 
 ## 1.3.4
 - updated to GCC 12.1.0, binutils, GNU gdb (GDB) 13.0.50.20220509-git

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/amigaDebug.ts b/src/amigaDebug.ts
@@ -598,7 +598,6 @@ export class AmigaDebugSession extends LoggingDebugSession {
 	}
 
 	protected readMemoryRequest(response: DebugProtocol.ReadMemoryResponse, args: DebugProtocol.ReadMemoryArguments, request?: DebugProtocol.Request) {
-		//const address = parseInt(args.memoryReference, args.memoryReference.startsWith('0x') ? 16 : 10) + (args.offset || 0);
 		if(args.count === 0) {
 			response.body = {
 				address: args.memoryReference,
@@ -623,7 +622,7 @@ export class AmigaDebugSession extends LoggingDebugSession {
 	}
     protected writeMemoryRequest(response: DebugProtocol.WriteMemoryResponse, args: DebugProtocol.WriteMemoryArguments, request?: DebugProtocol.Request) {
 		// TODO
-		this.sendResponse(response);
+		this.sendErrorResponse(response, 114, `writeMemoryRequest not implemented yet`);
 	}
 
 	protected async customStartProfileRequest(response: DebugProtocol.Response, args: any, autoStop: boolean) {