Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-mdoc to 2.5.0 #14

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Update sbt-mdoc to 2.5.0 #14

merged 4 commits into from
Nov 8, 2023

Conversation

banno-diy-steward[bot]
Copy link

About this PR

πŸ“¦ Updates org.scalameta:sbt-mdoc from 2.4.0 to 2.5.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "sbt-mdoc" }
}]
labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

@banno-diy-steward banno-diy-steward bot requested a review from a team as a code owner November 7, 2023 16:23
@samspills
Copy link
Collaborator

build is failing because sbt-mdoc dropped support for java 8, but we still cross-compile for java 8. I'm looking into how we can limit site generation to just java 11 but without dropping 8 from our cross versions

@@ -21,8 +21,8 @@ val scalafixV = "0.11.1"
ThisBuild / crossScalaVersions := Seq(Scala213, "2.12.18")
ThisBuild / scalaVersion := Scala213 // the default Scala
ThisBuild / githubWorkflowJavaVersions := Seq(
JavaSpec.temurin("8"),
JavaSpec.temurin("11")
JavaSpec.temurin("11"), // the first java is the default java, don't change the order
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this correctly, it will publish with Java 11. I think that's fine for internal projects (and would like to know any where it's not, because this keeps coming up, and it's long past time). But if we proceed with that, I don't see a point to testing on Java 8.

Copy link
Collaborator

@samspills samspills Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true, because tlJdkRelease is still java 8, and that's what sets the target jvm version for the compiled code (I didn't know this yesterday, I've just been asking Arman about it πŸ˜…)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that should work. I knew about that setting, but its default value comes as a surprise. I suggest we set that one explicitly.

I'm going to start identifying projects on 8 and chasing them upward, because there are too many variants of this conversation right now for no known (to me) users.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just pushed that change!

@samspills samspills merged commit 7fd0dba into main Nov 8, 2023
7 checks passed
@samspills samspills deleted the update/sbt-mdoc-2.5.0 branch November 8, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants