BS-123 #81
Closed
BS-123 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o, build the jar and include it in the execution classpath
sivareddyp
reviewed
Aug 4, 2023
.github/workflows/build_publish.yml
Outdated
| @@ -4,9 +4,9 @@ on: | |||
| branches: | |||
| - snomed-master | |||
| - 'snomed-release-*' | |||
| - reports-issue | |||
| @@ -0,0 +1,33 @@ | |||
| FROM amazoncorretto:8 | |||
There was a problem hiding this comment.
where are you using newly created file ?
|
|
||
| RUN cp /opt/bahmni-reports-extension-icd10/target/extensions-1.0-SNAPSHOT.jar ${WAR_DIRECTORY}/WEB-INF/lib/extensions-1.0-SNAPSHOT.jar |
There was a problem hiding this comment.
please follow semantic versioning for version
| @@ -99,7 +99,7 @@ private void enrichUsingReflection(String extensionClassStr, Collection<Map<Stri | |||
| Constructor constructor = extensionClass.getDeclaredConstructor(); | |||
| constructor.setAccessible(true); | |||
| ResultSetExtension extension = (ResultSetExtension) constructor.newInstance(); | |||
| extension.enrich(collection, jasperReport); | |||
| extension.enrich(collection, jasperReport);//enrich | |||
sivareddyp
reviewed
Aug 4, 2023
| @@ -22,7 +24,10 @@ COPY target/bahmnireports.war /etc/bahmni-reports/bahmnireports.war | |||
| RUN cd ${WAR_DIRECTORY} && jar xvf /etc/bahmni-reports/bahmnireports.war | |||
|
|
|||
| ADD https://repo.mybahmni.org/packages/build/bahmni-embedded-tomcat-8.0.42.jar /opt/bahmni-reports/lib/bahmni-embedded-tomcat.jar | |||
| RUN cd /opt/ && git clone https://github.com/Bahmni/bahmni-reports-extension-icd10.git | |||
| RUN cd /opt/bahmni-reports-extension-icd10 && mvn clean install | |||
There was a problem hiding this comment.
you can remove the directory /opt/bahmni-reports-extension-icd10 after copying of jar file
|
Not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Workflows to clone ICD10 extensions repository, build the jar and add the jar to the execution classpath
Screenshot
JIRA tickets
https://bahmni.atlassian.net/browse/BS-123