Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools as a runtime dependency #479

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

vishwin
Copy link
Contributor

@vishwin vishwin commented Mar 5, 2024

setuptools is not actually used in any runtime code. Only liccheck during lint uses it for pkg_resources, which has long been deprecated (and is more liccheck's problem to migrate away). liccheck also does not yet officially support Python 3.12, otherwise I would think they would explicitly specify the setuptools dependency themselves.

The only reason why setuptools would be present in a runtime environment is for pkg_resources, whose functionality has been replaced by packaging and the importlib suite. Otherwise, setuptools pollutes the environment, particularly at the operating system distribution level. Many Python packages have not adopted PEP 517 and still execute setup.py directly, functionality that setuptools deprecated in 58 and no longer supports after. Multiple setuptools cannot exist in the same environment.

@mjurbanski-reef
Copy link
Collaborator

seems like leftover from old days, thank you for fixing this!

@mjurbanski-reef mjurbanski-reef merged commit 86f28dc into Backblaze:master Mar 5, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants