Update departments account and org from Tracy. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/logic/userInsertFunctions.py
Outdated
| Tracy data. | ||
| """ | ||
| studentsInDB = Student.select() | ||
| supervisorsInDB = Supervisor.select() | ||
| departmentsFromDB = Department.select() |
There was a problem hiding this comment.
Not a blocker and really nitpicky but I think it would be nice to keep naming the same on all of these so it would be departmentsInDB
sreynit02
requested changes
Mar 22, 2023
app/logic/userInsertFunctions.py
Outdated
| Tracy data. | ||
| """ | ||
| studentsInDB = Student.select() | ||
| supervisorsInDB = Supervisor.select() | ||
| departmentsFromDB = Department.select() |
| @@ -91,6 +91,13 @@ def getDepartments(self): | |||
| return STUPOSN.query.with_entities(STUPOSN.ORG, STUPOSN.DEPT_NAME, STUPOSN.ACCOUNT) \ | |||
| .distinct().order_by(STUPOSN.DEPT_NAME).all() | |||
|
|
|||
| def getDepartmentsFromName(self, deptName): | |||
| """ | |||
There was a problem hiding this comment.
You might consider correcting the name of the function. getDepartmentsFromName implies that you are getting multiple departments, which is not true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed PR #378
Summary: This PR changes the file
updateStudentRecords.pytoupdateDBRecords.py. We then add to that file a count of failed and updated department codes. InuserInsertFunctions.pywe add a new function that will update all department account and org codes based on what Tracy has for that department name. We also added a new function to Tracy to get department data from a department name and return the account and org code. We also added to the test suite to include the new department updating function and updated a test that resulted from adding a new department to UTE.To Test: Run the test suite. Reset from-backup and export flask environment to staging. Not in the terminal type "python updateDBRecords.py" and you will see that some fail and some pass. Fails are from departments that no longer exist. Success proves that the new function updates departments.