Clarified Form Validation for Instructors on the SLC Page #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #1367
When we create an SLC form, on the second page where we need to select the instructor, there should be more clarification.
As of now, if the instructor for a course is not selected, it won't let the user continue to the third page. However, to select the instuctor, the user needs to click on the names appearing when they start typing the name of the instructor. If they don't click on the option with the instructor's name, and type the full name by themselves, it appears an instructor is selected when, in reality, there is not and it is not clear for the user why they can't proceed to the next page.
Changes
I did a few things to enhance transparency:
There's a message that appears when no instructors have been added to the page
Attempting to move onto the next page now highlights the empty table instead of the search field
The search bar now has a tooltip explaining that a click is required in order to add them to the instructor table
I also made it so that the first name in the searched list is autofocused by default and can be conveniently added to the table by pressing enter.
The search box now empties itself when you stop focusing it. This avoids any misunderstanding that you added a course instructor without clicking on their search result.
*unfocus
Testing
In order to test, navigate to the course proposals tab,
Create a new course proposal
Navigate to the second page (tab) of the form.
Finally, pretend you've never interacted with the search instructor field and make sure its intuitive what went wrong when you try to navigate to the next page without entering a course instructor and that its intuitive how to add an instructor to the list.
Two instructors in the test database you can use are
Finn Bledsoe
andBrian Ramsay