Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] 혜택페이지 카테고리 클릭 이후 뒤로가기 동작 시 히스토리 남기는 기능 제거 #614

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[QA] 혜택페이지 카테고리 클릭 이후 뒤로가기 동작 시 히스토리 남기는 기능 제거 #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/Store/StoreBenefitPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function StoreBenefitPage() {
current_page: value,
duration_time: (new Date().getTime() - Number(sessionStorage.getItem('enterMain'))) / 1000,
});
setParams('category', `${id}`, { deleteBeforeParam: false, replacePage: false });
setParams('category', `${id}`, { deleteBeforeParam: true, replacePage: true });
};

return (
Expand Down
27 changes: 15 additions & 12 deletions src/utils/hooks/routing/useParamsHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,28 @@ import { useSearchParams } from 'react-router-dom';
const useParamsHandler = () => {
const [searchParams, setSearchParams] = useSearchParams();
const params = Object.fromEntries(searchParams);

const setParams = (
key: string,
value: string,
option: {
deleteBeforeParam: boolean,
replacePage: boolean,
},
deleteBeforeParam?: boolean;
replacePage?: boolean;
} = {},
) => {
if (option.deleteBeforeParam) {
const param = searchParams.get(key);
if (param) {
searchParams.delete(key);
setSearchParams(searchParams, { replace: option.replacePage });
return;
}
const { deleteBeforeParam = false, replacePage = false } = option;

const newSearchParams = new URLSearchParams(searchParams);
Copy link
Contributor

@D0Dam D0Dam Dec 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새롭게 객체를 선언해서 써주고 있는데 set함수의 첫번째 인자로 그 전값을 가져와서 넣어줘도 되는 과정이 아닐까 하는데 어떻게 생각하나요? 혹은 새롭게 객체 선언을 했을때의 이점이 있을까요?

setSearchParams((prev) => ..., ...)
// 요런식으로 전값을 가져와서 고치기

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searchParams를 트리거로 렌더링을 변화하는 경우가 있어 만약 해당 경우에 변경을 React에서 감지할 수 있도록 하기 위해서입니다.
React는 얕은 비교를 수행하기에 객체를 생성하여 하는 방식으로 사용했습니다.


if (deleteBeforeParam) {
newSearchParams.delete(key);
}
searchParams.set(key, value);
setSearchParams(searchParams, { replace: option.replacePage });

newSearchParams.set(key, value);

setSearchParams(newSearchParams, { replace: replacePage });
};

return {
params,
searchParams,
Expand Down
Loading