[INQUIRY] 문의하기 페이지 기능 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 새로고침을 통해 post 요청 반영 - hooks 파일 위치 변경 - useRefreshInquiryData 생성
- 이후 개발 사항
junghaesung79
requested review from
chaeseungyun,
hyejun0228,
KimKyungYun,
kimeodml,
LUNA-KK,
20HyeonsuLee and
HAEROOL
as code owners
kimeodml
reviewed
Dec 27, 2023
- maxLength -> MAX_LENGTH
- interface 이름 변경
ChoiWonBeen
reviewed
Dec 31, 2023
ChoiWonBeen
reviewed
Dec 31, 2023
src/pages/Inquiry/Inquiry/components/InquiryList/InquiryBlock/index.tsx
Outdated
Show resolved
Hide resolved
- queryKey ['inquiry', idCursor] -> ['inquiry']
- 의존성 수정 - IntersectionObserver의 콜백 로직 변경
# Conflicts: # src/pages/Inquiry/Inquire/components/InquireForm/index.tsx # src/pages/Inquiry/Inquire/index.tsx # src/pages/Inquiry/Inquiry/components/InquiryList/InquiryBlock/index.tsx # src/pages/Inquiry/Inquiry/components/InquiryList/index.tsx # src/pages/Inquiry/Inquiry/components/InquirySelectButton/index.tsx # src/pages/Inquiry/Inquiry/hooks/useInquiryList.ts # src/pages/Inquiry/Inquiry/index.tsx
- useMeme, useCallback 사용 - 함수 축약
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
ChoiWonBeen
reviewed
Jan 7, 2024
hanagertrudeKim
approved these changes
Jan 9, 2024
- inquiryImages 옵셔널 해제
- useImageList차용 => useInquiryImages
- queryType 타입 단언
LUNA-KK
approved these changes
Jan 9, 2024
LUNA-KK
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#99] request
문의하기 페이지의 기능을 구현했습니다.
코드 양이 많아질 것 같아 이미지를 넣은 양식의 제출 기능은 미완성인 상태로 pr합니다.
useSubmitInquiry 부분에서 문의하기 요청을 한 다음 navigate로 문의사항 페이지로 이동했을 때 문의 내용이 적용이 되지 않아서 window.location.reload()하는 방법을 썼는데 이 방법 말고 다른 좋은 방법이 있을까요?
queryClient.invalidateQueries({ queryKey: ['inquiry'] }) 해봤지만 생각대로 되지 않았습니다.
문의 사항을 보는 부분의 로직을 변경하여 해결하였습니다!
Please check if the PR fulfills these requirements
developbranch, not themainbranchyarn lintScreenshot