Adding Extensibility for Custom Signed Assertion Providers #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jennyf19
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
…rCustomSignedAssertion.cs Co-authored-by: jennyf19 <[email protected]>
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
I mistook "log a new error" from the spec for throw a new exception |
This comment was marked as resolved.
This comment was marked as resolved.
jmprieur
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/CertificateErrorMessage.cs
Outdated
Show resolved
Hide resolved
|
Let's have an aka.ms link for the error messages for this feature. |
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
Co-authored-by: Jean-Marc Prieur <[email protected]>
Co-authored-by: jennyf19 <[email protected]>
…omSignedAssertionProvider
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
jennyf19
approved these changes
Feb 6, 2025
SummarySummary
CoverageNo assemblies have been covered. |
...rosoft.Identity.Web.TokenAcquisition/ConfidentialClientApplicationBuilderExtension.Logger.cs
Show resolved
Hide resolved
SummarySummary
CoverageNo assemblies have been covered. |
... Tests/CustomSignedAssertionProviderTests/CustomSignedAssertionProviderExtensibilityTests.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageNo assemblies have been covered. |
... Tests/CustomSignedAssertionProviderTests/CustomSignedAssertionProviderExtensibilityTests.cs
Outdated
Show resolved
Hide resolved
tests/E2E Tests/CustomSignedAssertionProviderTests/CustomSignedAssertionProviderTests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Keegan <[email protected]>
…dAssertionProviderExtensibilityTests.cs Co-authored-by: Keegan <[email protected]>
…dAssertionProviderTests.csproj Co-authored-by: Keegan <[email protected]>
SummarySummary
CoverageNo assemblies have been covered. |
keegan-caruso
approved these changes
Feb 6, 2025
SummarySummary
CoverageNo assemblies have been covered. |
JoshLozensky
deleted the
lozensky/AddCustomSignedAssertionExtensibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extensibility for customers to be able to define their own signed assertion providers. The integration test in \tests\E2E Tests\CustomSignedAssertionProviderTests\CustomSignedAssertionProviderExtensibilityTests.cs has an example of the sort of work a customer would need to do in order to use this functionality.
Fixes #3220