Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing 3212 and cleaning-up technical debt #3213

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Fixing 3212 and cleaning-up technical debt #3213

merged 3 commits into from
Jan 23, 2025

Conversation

jmprieur
Copy link
Collaborator

Fixing 3212 and cleaning-up technical debt

Description

  • Adopts Abstractions 8.0, which removes the public properties Container and ValueOrReference on CredentialDescriptions, that were for compatibility with IdWeb 1.x
  • Clean-up the tests that were using these properties instead of using the right properties. Some of these were using theories for one case

Fixes #3212

@jmprieur jmprieur requested a review from a team as a code owner January 23, 2025 00:39
kllysng
kllysng reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@kllysng kllysng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Microsoft.Identity.Web.xml need to be updated?

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 1/23/2025 - 3:45:26 AM
Coverage date: 1/23/2025 - 3:44:19 AM - 1/23/2025 - 3:45:16 AM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@jmprieur jmprieur merged commit 990a2ba into master Jan 23, 2025
4 checks passed
@jmprieur jmprieur deleted the jmprieur/Fix3212 branch January 23, 2025 03:47
@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 1/23/2025 - 4:03:41 AM
Coverage date: 1/23/2025 - 4:02:37 AM - 1/23/2025 - 4:03:32 AM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kllysng kllysng kllysng left review comments

@JoshLozensky JoshLozensky JoshLozensky approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Identity.Web 3.6.1 Giving "AADSTS7000215: Invalid client secret provided..."
4 participants
@jmprieur @jennyf19 @kllysng @JoshLozensky