Adding Extensibility for Custom Signed Assertion Providers #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
jennyf19
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
| if (CredentialSourceLoaders.TryGetValue(credentialDescription.SourceType, out ICredentialSourceLoader? loader)) | ||
| if (credentialDescription.SourceType == CredentialSource.CustomSignedAssertion) | ||
| { | ||
| await ProcessCustomSignedAssertionAsync(credentialDescription, parameters); |
There was a problem hiding this comment.
This method throws, but we don't catch the exception, which btw is internal?
There was a problem hiding this comment.
@jmprieur
I'm a bit confused as to why we would need to catch it here since it is logged inside the ProcessCustomSignedAssertionAsync method. In the similar example on lines 87 and 88 for other source types when we do catch the exception, we do so to log it before throwing.
There was a problem hiding this comment.
We don't need to throw at all in the extensibility (the code you are adding). We are in control of that code. But we need to catch the exception sent by the extensions (the code that extenders will write). So indeed, you should have something like line 83
…rCustomSignedAssertion.cs Co-authored-by: jennyf19 <[email protected]>
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageNo assemblies have been covered. |
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
I mistook "log a new error" from the spec for throw a new exception |
SummarySummary
CoverageNo assemblies have been covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO write description :)
Fixes #3220