Reverting the skipping of strongbox for android 14 #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What : Reverting changes made in these PRs #2158 and #2053
Why : Changes made in PRs mentioned above are for addressing a key store error happening on Android 14. We were skipping using strongbox when -1000 error was thrown. This error was being thrown all the time on Android 14. I created a bug on google 6 months back and they finally sent an update to check if it is fixed :)
Testing : Reverted the changes made previously and tested on Android 14 device. Triggered AT POP flow from MsalTestApp and it succeeded. In the logs, I can see that key pair generation was successful and it was using strongbx.
NOTE : not merging this until end of May for the change to propogate to all OEMs