Initial work to get ado token command working.
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillysiemens
previously approved these changes
Mar 10, 2023
mvanchaa
previously approved these changes
Mar 10, 2023
kyle-rader-msft
dismissed stale reviews from mvanchaa and reillysiemens
via
0d45e39
kyle-rader-msft
force-pushed
the
user/kyrader/token2
branch
from
eb97054
to
0d45e39
Compare
kyle-rader-msft
force-pushed
the
user/kyrader/token2
branch
from
0d45e39
to
0a2ea77
Compare
shalinikhare27
requested changes
Mar 15, 2023
I've opened a PR to migrate to Sonar Lint, and can then work on cleaning up it's warnings. StyleCop inherently isn't going to work because it's not updating for modern versions of C#. |
reillysiemens
approved these changes
Mar 16, 2023
shalinikhare27
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a functioning version of the
ado tokencommand.There is refactoring cleanup work that will come after this to extract the common logic into a more testable flow that's re-usable by the
ado patandaadcommands.