Propagate user app panics to SF for async apis #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsajwani
approved these changes
Dec 2, 2024
youyuanwu
force-pushed
the
users/youyuanwu/propagate-panic-to-sf
branch
from
1af46bd to
9ff8ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously user app code panics in the SF callback/notification code causes the process to exit.
This PR changes this behavior: for all SF async api notifications with Begin and End calls, mssf provides user an async function to implement. If user function panics, mssf considers the callback/notification failed with error code E_UNEXPECTED and returns this error code to SF.
For synchronous apis that user implements, the panic is unhandled and will cause process to terminate, because mssf currently does not do anything for synchronous SF calls, user app code is directly executed on SF threads.