Skip to content

Commit

Permalink
Remove lld linker option and dependencies (#112)
Browse files Browse the repository at this point in the history
Originally lld was used for linking with SF shared libs due to SF shared
libs incompatibility with ld.
Now SF shared libs are dynamically loaded instead of linked, there is no
need to use lld anymore.
Removes cargo lld linker option.
  • Loading branch information
youyuanwu authored Dec 28, 2024
1 parent caf742a commit c18570a
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 10 deletions.
4 changes: 0 additions & 4 deletions .cargo/config.toml

This file was deleted.

2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs > ./rustup.sh
RUN chmod u+x ./rustup.sh && ./rustup.sh -y

# more tools for dev
RUN apt-get install git clang lld -y
RUN apt-get install git clang -y
RUN pip install cmake --upgrade

# expose sf shared libs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: apt-get
run: sudo apt-get update && sudo apt-get install apt-transport-https curl lsb-release wget gnupg2 software-properties-common debconf-utils clang lld -y
run: sudo apt-get update && sudo apt-get install apt-transport-https curl lsb-release wget gnupg2 software-properties-common debconf-utils clang -y

- name: install sf
run: |
Expand Down
4 changes: 0 additions & 4 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,4 @@ cmake --build build --target generate_rust
cargo run -p tools_api
```

## Notes
1. GCC ld linker has problems with SF .so file so we use lld from LLVM/Clang which is configured in `.cargo/config.toml`
2. `fabric_pal.so` is needed to be able to provide Windows C functions needed by windows-rs. Code is checked-in in `/bintemp` folder.


0 comments on commit c18570a

Please sign in to comment.