Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow_timeout_in_minutes to VNETs. #663

Conversation

SteffenBoThomsen
Copy link
Contributor

Problem

When either using a Firewall in a brown field deployment or deploying a firewall through SDAF in a green field deployment. It's important to set the VNET flow timeout in accordance with the Firewall idle timeout.

As the idle timeout can be increased only by request to Microsoft support, we can't infer the actual value to set and should therefore delegate to the users.

Furthermore, when having a firewall not controlled by SDAF, it should be possible to disable route propagation on route tables manually.

Solution

Add the option to specify *_flow_timeout_in_minutes for management and workload zone VNETs, defaults to null.
Add the option to specify network_enable_route_propagation for subnet route tables, defaults to true.

@SteffenBoThomsen SteffenBoThomsen marked this pull request as ready for review November 11, 2024 10:55
@SteffenBoThomsen SteffenBoThomsen requested a review from a team as a code owner November 11, 2024 10:55
@SteffenBoThomsen SteffenBoThomsen requested review from mkdeegan and removed request for a team November 11, 2024 10:55
@hdamecharla hdamecharla self-requested a review November 11, 2024 11:17
@hdamecharla hdamecharla self-assigned this Nov 11, 2024
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hdamecharla hdamecharla merged commit 43ecff8 into Azure:development Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants