Bring in HotFix repairs #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…installation and Azure CLI installation
…r.sh and fixing Terraform ownership
…r.sh and fixing Terraform ownership
…nt for deployer and storage_sapbits_contributor
…installation and Azure CLI installation
…r.sh and fixing Terraform ownership
…nt based on VM count
…nt based on VM count and use managed service identity (MSI) for authentication
…ng Terraform ownership
…nt based on VM count and use managed service identity (MSI) for authentication
…nt based on VM count and use managed service identity (MSI) for authentication
…replaced with other values in child scripts
… for authentication
…e managed service identity (MSI) for authentication
…ed service identity (MSI) for authentication
…e managed service identity (MSI) for authentication
… for authentication
…e principal object_id
… for authentication and remove unnecessary ARM_USE_MSI variable
… for authentication
…e principal object_id Refactor installer.sh to comment out unnecessary terraform output command
added 16 commits
October 23, 2024 10:42
…he count condition
…he count condition
…r_keyvaults_and_storage in the default_action condition
…r_environment_variables
…r_environment_variables
…r_environment_variables and remove error file
KimForss
added a commit
that referenced
this pull request
Oct 31, 2024
* Bring in HotFix repairs (#651) * Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]> * ansible python fix (#653) Co-authored-by: swatibehl <[email protected]> * Fix conditional statement in install_workloadzone.sh * Pipeline hotfixes (#654) * Refactor echo statements in deploy control plane pipeline * Refactor install_workloadzone.sh script to reset return_value variable * Refactor install_workloadzone.sh script to improve error handling * feng shui * Refactor variables_local.tf to improve readability and error handling * Refactor deploy control plane pipeline to include deployer_tfstate_key parameter * Refactor deploy control plane pipeline to include deployer_tfstate_key and landscape_tfstate_key parameters * Refactor echo statement in deploy control plane pipeline * Refactor remover script in deploy control plane pipeline * Refactor deploy control plane pipeline to remove unnecessary use_msi flag * Refactor deploy control plane pipeline to update default value for spn_keyvault_id * Refactor deploy control plane pipeline to update default value for spn_key_vault_arm_id * Refactor deploy control plane pipeline to trim deployer_tfstate_key in imports.tf * Refactor deploy control plane pipeline to include provider for azurerm.workload in imports.tf * Refactor deploy control plane pipeline to update storage account authentication and export TF_VAR_tfstate_resource_id * Refactor deploy control plane pipeline to update deployer and landscape state file paths * Refactor deploy control plane pipeline to remove unnecessary code in remover.sh * Refactor install_workloadzone.sh to export SPN key vault ID if keyvault is provided * Refactor tfvar_variables.tf to set default value of short_named_endpoints_nics to true * Refactor remover.sh to consolidate terraform destroy command * Refactor echo statements in remover.sh and remove-control-plane.yaml * Refactor echo statements in deploy/pipelines/01-deploy-control-plane.yaml * Refactor providers.tf to conditionally set use_msi based on var.use_spn * Refactor echo statements in deploy/pipelines/01-deploy-control-plane.yaml to improve clarity of deployment credentials * Refactor install_workloadzone.sh to improve argument parsing and readability * Refactor code for improved argument parsing and readability in install_workloadzone.sh * Refactor LandscapeModel.cs, LandscapeDetails.json, and LandscapeTemplate.txt to add prevent_deletion_if_contains_resources property * Refactor package dependencies in os-packages.yaml * Refactor ansible role to remove unused variable and update passlib dependency * Refactor echo statement in install_workloadzone.sh for improved clarity --------- Co-authored-by: Kimmo Forss <[email protected]> * Suse 12 fix for python (#656) * suse 12 fix for python * Update 1.17.1-pre_checks.yml * Update 1.17.1-pre_checks.yml Fix linting issues --------- Co-authored-by: swatibehl <[email protected]> Co-authored-by: hdamecharla <[email protected]> * SLES 12 SP5 fixes (#658) * Fix conditional statement in install_workloadzone.sh * Fix subscription_id assignment in providers.tf * Fix indentation in deployment credential messages * Fix deployment credential messages and subscription_id assignment * chore: enable Azure scheduled events resource start and display output on SUSE * Refactor deployment script to improve readability and remove unnecessary output * Update provider version to 4.7 * Refactor tfvar_variables.tf to add a new variable for preventing deletion of resource groups with resources * Add prevent_deletion_if_contains_resources variable to SystemModel.cs * Refactor deployment script to improve readability and display deployment credentials * Refactor deployment script to enable Stonith and concurrent fencing * Refactor tfvar_variables.tf to add prevent_deletion_if_contains_resources variable * Refactor validate.yml to remove single quotes from crm_resource output * Refactor validate.yml to remove single quotes from crm_resource output * fix ansible schema errors * Refactor validate.yml to remove unnecessary 'when' condition --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]> * extend timeout for zypp (#657) Co-authored-by: swatibehl <[email protected]> --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: Swatibehl <[email protected]> Co-authored-by: swatibehl <[email protected]>
hdamecharla
added a commit
that referenced
this pull request
Oct 31, 2024
* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include azurerm_role_assignment for deployer and storage_sapbits_contributor * Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count * Refactor deploy scripts to simplify checkIfCloudShell function * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy scripts to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * handle the realfilepath and the scriptdir variables as they might be replaced with other values in child scripts * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_utils.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor installer.sh to include terraform output command * Refactor installer.sh to comment out unnecessary terraform output command * Refactor variables_local.tf to use client_id instead of id for service principal object_id * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication and remove unnecessary ARM_USE_MSI variable * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * chore: include OpenSSF Scorecard badge * Refactor variables_local.tf to use client_id instead of id for service principal object_id Refactor installer.sh to comment out unnecessary terraform output command * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to include ARM_OBJECT_ID variable * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * check terraform when running in cloudshell * Refactor pipeline script to include missing variable checks * Refactor pipeline script to remove unnecessary variable checks * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to include missing variable checks * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements and export variables for installation method and workload ARM_CLIENT_ID * Refactor pipeline script to update PATH variable in deploy_controlplane.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statement for displaying the key vault information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update usage of Azure CLI command in installer.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor provider configuration to use Azure Key Vault for subscription ID retrieval * Fixes #1: Added a new line to the installer script * Refactor pipeline script to fix unzip command in deploy control plane stage * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor deploy_controlplane.sh script to save deployer_tfstate_key in config information * remove the deployer provider * Refactor deploy_controlplane.sh script to use the azurerm.deployer provider for retrieving key vault secrets * Refactor tfvar_variables.tf to add "tags" variable for providing tags to all resources * Refactor providers.tf to use local variable for subscription_id in deployer provider * Refactor providers.tf to remove subscription_id from deployer provider * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor azurerm provider versions to 4.6.0 * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Add SPN to workload zone key vault * Remove the permission setting from the pipeline * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in deploy_utils.sh for better readability * Refactor echo statement in 03-sap-system-deployment.yaml * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statement to use variable for Terraform Storage Account Id * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently and for Terraform details * Refactor echo statements to consistently use variables * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Debugging * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * trimming * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * terraform * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve Terraform details * Refactor providers.tf to use Managed Service Identity (MSI) for authentication * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statement to improve parameter file formatting * Refactor echo statements to improve formatting and use variables consistently * Refactor echo statements to consistently use variables and improve formatting * Refactor deploy control plane pipeline to improve configuration and extension installation * Refactor providers.tf to use remote state for subscription ID * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting Refactor providers.tf to use remote state for subscription ID Refactor deploy control plane pipeline to improve configuration and extension installation Fix validation issue in script_helpers.sh Update providers.tf to handle null subscription ID Remove unused variable in variables_local.tf * Refactor echo statement to improve formatting in deploy_controlplane.sh * Refactor echo statements to improve formatting in deploy_controlplane.sh and script_helpers.sh * Refactor deploy_controlplane.sh and script_helpers.sh echo statements for improved formatting * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor echo statements for improved formatting in deploy_controlplane.sh and script_helpers.sh * Refactor permissions assignment in deploy_controlplane.sh * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Change to use ARM CLIENT ID * Refactor echo statement to include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements and include deployer subscription in 02-sap-workload-zone.yaml Change to use WL_ARM_CLIENT_ID instead of ARM_CLIENT_ID Update variable group and variable names in New-SDAFDevopsWorkloadZone.ps1 Update echo statements in script_helpers.sh for improved formatting * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * indentation * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and fix indentation in 10-remover-terraform.yaml * Refactor echo statement for improved formatting in remover.sh * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in 01-deploy-control-plane.yaml * Refactor validate_dependencies function to check for the existence of the terraform binary file instead of the terraform directory. * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor azuread_service_principal data source to conditionally include object_id in locals * Update SDAF version to 3.13.1.0 in ansible-input-api.yaml and version.txt * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh and providers.tf * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor installer.sh to fix path issue and pass parameters correctly * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include deployer subscription parameter and persist parameters * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call and handle storage account authentication * Refactor deploy_controlplane.sh to remove unnecessary echo statement * Refactor deploy_controlplane.sh to remove unnecessary echo statements and improve parameter handling * Refactor deploy_controlplane.sh to improve parameter handling * Refactor deploy_controlplane.sh to improve storage account authentication handling * Refactor deploy_controlplane.sh to improve parameter handling and remove unnecessary echo statements * Refactor deploy_utils.sh to fix variable value retrieval from config file * Refactor parameter handling in script_helpers.sh and install_workloadzone.sh * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to remove unnecessary code * Refactor echo statements to improve readability and consistency * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to remove unnecessary echo statements * Refactor installer.sh to improve parameter handling and region code handling * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Keyvault network rules * Refactor key_vault_sap_landscape.tf to include var.enable_firewall_for_keyvaults_and_storage in the default_action condition * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor module.tf to include enable_firewall_for_keyvaults_and_storage variable * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables and remove error file * Add Terraform output detaisl * Refactor Terraform plugin cache directory handling * Refactor Terraform destroy command in remover.sh * Refactor Terraform destroy command in remover.sh * Refactor echo statement in deploy pipeline to include return code from deployment * Refactor echo statement in deploy pipeline to include return code from deployment --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]>
KimForss
added a commit
to KimForss/sap-automation
that referenced
this pull request
Oct 31, 2024
* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include azurerm_role_assignment for deployer and storage_sapbits_contributor * Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count * Refactor deploy scripts to simplify checkIfCloudShell function * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy scripts to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * handle the realfilepath and the scriptdir variables as they might be replaced with other values in child scripts * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_utils.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor installer.sh to include terraform output command * Refactor installer.sh to comment out unnecessary terraform output command * Refactor variables_local.tf to use client_id instead of id for service principal object_id * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication and remove unnecessary ARM_USE_MSI variable * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * chore: include OpenSSF Scorecard badge * Refactor variables_local.tf to use client_id instead of id for service principal object_id Refactor installer.sh to comment out unnecessary terraform output command * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to include ARM_OBJECT_ID variable * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * check terraform when running in cloudshell * Refactor pipeline script to include missing variable checks * Refactor pipeline script to remove unnecessary variable checks * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to include missing variable checks * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements and export variables for installation method and workload ARM_CLIENT_ID * Refactor pipeline script to update PATH variable in deploy_controlplane.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statement for displaying the key vault information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update usage of Azure CLI command in installer.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor provider configuration to use Azure Key Vault for subscription ID retrieval * Fixes #1: Added a new line to the installer script * Refactor pipeline script to fix unzip command in deploy control plane stage * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor deploy_controlplane.sh script to save deployer_tfstate_key in config information * remove the deployer provider * Refactor deploy_controlplane.sh script to use the azurerm.deployer provider for retrieving key vault secrets * Refactor tfvar_variables.tf to add "tags" variable for providing tags to all resources * Refactor providers.tf to use local variable for subscription_id in deployer provider * Refactor providers.tf to remove subscription_id from deployer provider * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor azurerm provider versions to 4.6.0 * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Add SPN to workload zone key vault * Remove the permission setting from the pipeline * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in deploy_utils.sh for better readability * Refactor echo statement in 03-sap-system-deployment.yaml * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statement to use variable for Terraform Storage Account Id * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently and for Terraform details * Refactor echo statements to consistently use variables * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Debugging * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * trimming * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * terraform * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve Terraform details * Refactor providers.tf to use Managed Service Identity (MSI) for authentication * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statement to improve parameter file formatting * Refactor echo statements to improve formatting and use variables consistently * Refactor echo statements to consistently use variables and improve formatting * Refactor deploy control plane pipeline to improve configuration and extension installation * Refactor providers.tf to use remote state for subscription ID * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting Refactor providers.tf to use remote state for subscription ID Refactor deploy control plane pipeline to improve configuration and extension installation Fix validation issue in script_helpers.sh Update providers.tf to handle null subscription ID Remove unused variable in variables_local.tf * Refactor echo statement to improve formatting in deploy_controlplane.sh * Refactor echo statements to improve formatting in deploy_controlplane.sh and script_helpers.sh * Refactor deploy_controlplane.sh and script_helpers.sh echo statements for improved formatting * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor echo statements for improved formatting in deploy_controlplane.sh and script_helpers.sh * Refactor permissions assignment in deploy_controlplane.sh * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Change to use ARM CLIENT ID * Refactor echo statement to include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements and include deployer subscription in 02-sap-workload-zone.yaml Change to use WL_ARM_CLIENT_ID instead of ARM_CLIENT_ID Update variable group and variable names in New-SDAFDevopsWorkloadZone.ps1 Update echo statements in script_helpers.sh for improved formatting * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * indentation * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and fix indentation in 10-remover-terraform.yaml * Refactor echo statement for improved formatting in remover.sh * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in 01-deploy-control-plane.yaml * Refactor validate_dependencies function to check for the existence of the terraform binary file instead of the terraform directory. * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor azuread_service_principal data source to conditionally include object_id in locals * Update SDAF version to 3.13.1.0 in ansible-input-api.yaml and version.txt * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh and providers.tf * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor installer.sh to fix path issue and pass parameters correctly * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include deployer subscription parameter and persist parameters * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call and handle storage account authentication * Refactor deploy_controlplane.sh to remove unnecessary echo statement * Refactor deploy_controlplane.sh to remove unnecessary echo statements and improve parameter handling * Refactor deploy_controlplane.sh to improve parameter handling * Refactor deploy_controlplane.sh to improve storage account authentication handling * Refactor deploy_controlplane.sh to improve parameter handling and remove unnecessary echo statements * Refactor deploy_utils.sh to fix variable value retrieval from config file * Refactor parameter handling in script_helpers.sh and install_workloadzone.sh * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to remove unnecessary code * Refactor echo statements to improve readability and consistency * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to remove unnecessary echo statements * Refactor installer.sh to improve parameter handling and region code handling * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Keyvault network rules * Refactor key_vault_sap_landscape.tf to include var.enable_firewall_for_keyvaults_and_storage in the default_action condition * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor module.tf to include enable_firewall_for_keyvaults_and_storage variable * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables and remove error file * Add Terraform output detaisl * Refactor Terraform plugin cache directory handling * Refactor Terraform destroy command in remover.sh * Refactor Terraform destroy command in remover.sh * Refactor echo statement in deploy pipeline to include return code from deployment * Refactor echo statement in deploy pipeline to include return code from deployment --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]>
hdamecharla
added a commit
to hdamecharla/sap-automation
that referenced
this pull request
Nov 5, 2024
* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include azurerm_role_assignment for deployer and storage_sapbits_contributor * Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count * Refactor deploy scripts to simplify checkIfCloudShell function * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy scripts to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * handle the realfilepath and the scriptdir variables as they might be replaced with other values in child scripts * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_utils.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor installer.sh to include terraform output command * Refactor installer.sh to comment out unnecessary terraform output command * Refactor variables_local.tf to use client_id instead of id for service principal object_id * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication and remove unnecessary ARM_USE_MSI variable * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * chore: include OpenSSF Scorecard badge * Refactor variables_local.tf to use client_id instead of id for service principal object_id Refactor installer.sh to comment out unnecessary terraform output command * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to include ARM_OBJECT_ID variable * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * check terraform when running in cloudshell * Refactor pipeline script to include missing variable checks * Refactor pipeline script to remove unnecessary variable checks * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to include missing variable checks * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements and export variables for installation method and workload ARM_CLIENT_ID * Refactor pipeline script to update PATH variable in deploy_controlplane.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statement for displaying the key vault information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update usage of Azure CLI command in installer.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor provider configuration to use Azure Key Vault for subscription ID retrieval * Fixes Azure#1: Added a new line to the installer script * Refactor pipeline script to fix unzip command in deploy control plane stage * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor deploy_controlplane.sh script to save deployer_tfstate_key in config information * remove the deployer provider * Refactor deploy_controlplane.sh script to use the azurerm.deployer provider for retrieving key vault secrets * Refactor tfvar_variables.tf to add "tags" variable for providing tags to all resources * Refactor providers.tf to use local variable for subscription_id in deployer provider * Refactor providers.tf to remove subscription_id from deployer provider * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor azurerm provider versions to 4.6.0 * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Add SPN to workload zone key vault * Remove the permission setting from the pipeline * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in deploy_utils.sh for better readability * Refactor echo statement in 03-sap-system-deployment.yaml * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statement to use variable for Terraform Storage Account Id * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently and for Terraform details * Refactor echo statements to consistently use variables * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Debugging * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * trimming * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * terraform * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve Terraform details * Refactor providers.tf to use Managed Service Identity (MSI) for authentication * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statement to improve parameter file formatting * Refactor echo statements to improve formatting and use variables consistently * Refactor echo statements to consistently use variables and improve formatting * Refactor deploy control plane pipeline to improve configuration and extension installation * Refactor providers.tf to use remote state for subscription ID * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting Refactor providers.tf to use remote state for subscription ID Refactor deploy control plane pipeline to improve configuration and extension installation Fix validation issue in script_helpers.sh Update providers.tf to handle null subscription ID Remove unused variable in variables_local.tf * Refactor echo statement to improve formatting in deploy_controlplane.sh * Refactor echo statements to improve formatting in deploy_controlplane.sh and script_helpers.sh * Refactor deploy_controlplane.sh and script_helpers.sh echo statements for improved formatting * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor echo statements for improved formatting in deploy_controlplane.sh and script_helpers.sh * Refactor permissions assignment in deploy_controlplane.sh * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Change to use ARM CLIENT ID * Refactor echo statement to include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements and include deployer subscription in 02-sap-workload-zone.yaml Change to use WL_ARM_CLIENT_ID instead of ARM_CLIENT_ID Update variable group and variable names in New-SDAFDevopsWorkloadZone.ps1 Update echo statements in script_helpers.sh for improved formatting * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * indentation * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and fix indentation in 10-remover-terraform.yaml * Refactor echo statement for improved formatting in remover.sh * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in 01-deploy-control-plane.yaml * Refactor validate_dependencies function to check for the existence of the terraform binary file instead of the terraform directory. * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor azuread_service_principal data source to conditionally include object_id in locals * Update SDAF version to 3.13.1.0 in ansible-input-api.yaml and version.txt * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh and providers.tf * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor installer.sh to fix path issue and pass parameters correctly * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include deployer subscription parameter and persist parameters * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call and handle storage account authentication * Refactor deploy_controlplane.sh to remove unnecessary echo statement * Refactor deploy_controlplane.sh to remove unnecessary echo statements and improve parameter handling * Refactor deploy_controlplane.sh to improve parameter handling * Refactor deploy_controlplane.sh to improve storage account authentication handling * Refactor deploy_controlplane.sh to improve parameter handling and remove unnecessary echo statements * Refactor deploy_utils.sh to fix variable value retrieval from config file * Refactor parameter handling in script_helpers.sh and install_workloadzone.sh * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to remove unnecessary code * Refactor echo statements to improve readability and consistency * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to remove unnecessary echo statements * Refactor installer.sh to improve parameter handling and region code handling * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Keyvault network rules * Refactor key_vault_sap_landscape.tf to include var.enable_firewall_for_keyvaults_and_storage in the default_action condition * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor module.tf to include enable_firewall_for_keyvaults_and_storage variable * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables and remove error file * Add Terraform output detaisl * Refactor Terraform plugin cache directory handling * Refactor Terraform destroy command in remover.sh * Refactor Terraform destroy command in remover.sh * Refactor echo statement in deploy pipeline to include return code from deployment * Refactor echo statement in deploy pipeline to include return code from deployment --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]>
hdamecharla
added a commit
to hdamecharla/sap-automation
that referenced
this pull request
Nov 12, 2024
* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include azurerm_role_assignment for deployer and storage_sapbits_contributor * Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count * Refactor deploy scripts to simplify checkIfCloudShell function * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy scripts to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * handle the realfilepath and the scriptdir variables as they might be replaced with other values in child scripts * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_utils.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor installer.sh to include terraform output command * Refactor installer.sh to comment out unnecessary terraform output command * Refactor variables_local.tf to use client_id instead of id for service principal object_id * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication and remove unnecessary ARM_USE_MSI variable * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * chore: include OpenSSF Scorecard badge * Refactor variables_local.tf to use client_id instead of id for service principal object_id Refactor installer.sh to comment out unnecessary terraform output command * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to include ARM_OBJECT_ID variable * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * check terraform when running in cloudshell * Refactor pipeline script to include missing variable checks * Refactor pipeline script to remove unnecessary variable checks * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to include missing variable checks * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements and export variables for installation method and workload ARM_CLIENT_ID * Refactor pipeline script to update PATH variable in deploy_controlplane.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statement for displaying the key vault information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update usage of Azure CLI command in installer.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor provider configuration to use Azure Key Vault for subscription ID retrieval * Fixes Azure#1: Added a new line to the installer script * Refactor pipeline script to fix unzip command in deploy control plane stage * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor deploy_controlplane.sh script to save deployer_tfstate_key in config information * remove the deployer provider * Refactor deploy_controlplane.sh script to use the azurerm.deployer provider for retrieving key vault secrets * Refactor tfvar_variables.tf to add "tags" variable for providing tags to all resources * Refactor providers.tf to use local variable for subscription_id in deployer provider * Refactor providers.tf to remove subscription_id from deployer provider * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor azurerm provider versions to 4.6.0 * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Add SPN to workload zone key vault * Remove the permission setting from the pipeline * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in deploy_utils.sh for better readability * Refactor echo statement in 03-sap-system-deployment.yaml * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statement to use variable for Terraform Storage Account Id * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently and for Terraform details * Refactor echo statements to consistently use variables * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Debugging * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * trimming * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * terraform * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve Terraform details * Refactor providers.tf to use Managed Service Identity (MSI) for authentication * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statement to improve parameter file formatting * Refactor echo statements to improve formatting and use variables consistently * Refactor echo statements to consistently use variables and improve formatting * Refactor deploy control plane pipeline to improve configuration and extension installation * Refactor providers.tf to use remote state for subscription ID * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting Refactor providers.tf to use remote state for subscription ID Refactor deploy control plane pipeline to improve configuration and extension installation Fix validation issue in script_helpers.sh Update providers.tf to handle null subscription ID Remove unused variable in variables_local.tf * Refactor echo statement to improve formatting in deploy_controlplane.sh * Refactor echo statements to improve formatting in deploy_controlplane.sh and script_helpers.sh * Refactor deploy_controlplane.sh and script_helpers.sh echo statements for improved formatting * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor echo statements for improved formatting in deploy_controlplane.sh and script_helpers.sh * Refactor permissions assignment in deploy_controlplane.sh * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Change to use ARM CLIENT ID * Refactor echo statement to include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements and include deployer subscription in 02-sap-workload-zone.yaml Change to use WL_ARM_CLIENT_ID instead of ARM_CLIENT_ID Update variable group and variable names in New-SDAFDevopsWorkloadZone.ps1 Update echo statements in script_helpers.sh for improved formatting * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * indentation * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and fix indentation in 10-remover-terraform.yaml * Refactor echo statement for improved formatting in remover.sh * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in 01-deploy-control-plane.yaml * Refactor validate_dependencies function to check for the existence of the terraform binary file instead of the terraform directory. * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor azuread_service_principal data source to conditionally include object_id in locals * Update SDAF version to 3.13.1.0 in ansible-input-api.yaml and version.txt * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh and providers.tf * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor installer.sh to fix path issue and pass parameters correctly * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include deployer subscription parameter and persist parameters * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call and handle storage account authentication * Refactor deploy_controlplane.sh to remove unnecessary echo statement * Refactor deploy_controlplane.sh to remove unnecessary echo statements and improve parameter handling * Refactor deploy_controlplane.sh to improve parameter handling * Refactor deploy_controlplane.sh to improve storage account authentication handling * Refactor deploy_controlplane.sh to improve parameter handling and remove unnecessary echo statements * Refactor deploy_utils.sh to fix variable value retrieval from config file * Refactor parameter handling in script_helpers.sh and install_workloadzone.sh * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to remove unnecessary code * Refactor echo statements to improve readability and consistency * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to remove unnecessary echo statements * Refactor installer.sh to improve parameter handling and region code handling * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Keyvault network rules * Refactor key_vault_sap_landscape.tf to include var.enable_firewall_for_keyvaults_and_storage in the default_action condition * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor module.tf to include enable_firewall_for_keyvaults_and_storage variable * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables and remove error file * Add Terraform output detaisl * Refactor Terraform plugin cache directory handling * Refactor Terraform destroy command in remover.sh * Refactor Terraform destroy command in remover.sh * Refactor echo statement in deploy pipeline to include return code from deployment * Refactor echo statement in deploy pipeline to include return code from deployment --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]>
hdamecharla
added a commit
to hdamecharla/sap-automation
that referenced
this pull request
Nov 12, 2024
* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include azurerm_role_assignment for deployer and storage_sapbits_contributor * Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation * Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count * Refactor deploy scripts to simplify checkIfCloudShell function * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy scripts to include sourcing deploy_server.sh and fixing Terraform ownership * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication * handle the realfilepath and the scriptdir variables as they might be replaced with other values in child scripts * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_utils.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * Refactor installer.sh to include terraform output command * Refactor installer.sh to comment out unnecessary terraform output command * Refactor variables_local.tf to use client_id instead of id for service principal object_id * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication and remove unnecessary ARM_USE_MSI variable * Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication * chore: include OpenSSF Scorecard badge * Refactor variables_local.tf to use client_id instead of id for service principal object_id Refactor installer.sh to comment out unnecessary terraform output command * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to use correct variable for workload ARM subscription ID * Refactor pipeline script to include ARM_OBJECT_ID variable * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID * check terraform when running in cloudshell * Refactor pipeline script to include missing variable checks * Refactor pipeline script to remove unnecessary variable checks * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to include missing variable checks * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script * Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID * Refactor pipeline script to update echo statements and export variables for installation method and workload ARM_CLIENT_ID * Refactor pipeline script to update PATH variable in deploy_controlplane.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statement for displaying the key vault information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update usage of Azure CLI command in installer.sh * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor provider configuration to use Azure Key Vault for subscription ID retrieval * Fixes Azure#1: Added a new line to the installer script * Refactor pipeline script to fix unzip command in deploy control plane stage * Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information * Refactor deploy_controlplane.sh script to save deployer_tfstate_key in config information * remove the deployer provider * Refactor deploy_controlplane.sh script to use the azurerm.deployer provider for retrieving key vault secrets * Refactor tfvar_variables.tf to add "tags" variable for providing tags to all resources * Refactor providers.tf to use local variable for subscription_id in deployer provider * Refactor providers.tf to remove subscription_id from deployer provider * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor azurerm provider versions to 4.6.0 * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Refactor az keyvault set-policy command in deploy_controlplane.sh script * Add SPN to workload zone key vault * Remove the permission setting from the pipeline * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in script_helpers.sh and installer.sh * Refactor echo statements in deploy_utils.sh for better readability * Refactor echo statement in 03-sap-system-deployment.yaml * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statement in 03-sap-system-deployment.yaml for better readability * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements for better readability and consistency * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statements to use variable for workload TFvars * Refactor echo statement to use variable for Terraform Storage Account Id * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables for Terraform details * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently * Refactor echo statements to use variables consistently and for Terraform details * Refactor echo statements to consistently use variables * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Debugging * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * trimming * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * terraform * Refactor echo statements to consistently use variables and improve Terraform details * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve Terraform details * Refactor providers.tf to use Managed Service Identity (MSI) for authentication * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statement to improve parameter file formatting * Refactor echo statements to improve formatting and use variables consistently * Refactor echo statements to consistently use variables and improve formatting * Refactor deploy control plane pipeline to improve configuration and extension installation * Refactor providers.tf to use remote state for subscription ID * Refactor echo statements to consistently use variables and improve formatting * Refactor echo statements to consistently use variables and improve formatting Refactor providers.tf to use remote state for subscription ID Refactor deploy control plane pipeline to improve configuration and extension installation Fix validation issue in script_helpers.sh Update providers.tf to handle null subscription ID Remove unused variable in variables_local.tf * Refactor echo statement to improve formatting in deploy_controlplane.sh * Refactor echo statements to improve formatting in deploy_controlplane.sh and script_helpers.sh * Refactor deploy_controlplane.sh and script_helpers.sh echo statements for improved formatting * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor key vault secrets to include service principal access * Refactor echo statements for improved formatting in deploy_controlplane.sh and script_helpers.sh * Refactor permissions assignment in deploy_controlplane.sh * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Refactor echo statements for improved formatting and include deployer subscription * Change to use ARM CLIENT ID * Refactor echo statement to include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements and include deployer subscription in 02-sap-workload-zone.yaml Change to use WL_ARM_CLIENT_ID instead of ARM_CLIENT_ID Update variable group and variable names in New-SDAFDevopsWorkloadZone.ps1 Update echo statements in script_helpers.sh for improved formatting * Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * indentation * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml * Refactor echo statements for improved formatting and fix indentation in 10-remover-terraform.yaml * Refactor echo statement for improved formatting in remover.sh * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml * Refactor echo statements for improved formatting and remove unnecessary output in 01-deploy-control-plane.yaml * Refactor validate_dependencies function to check for the existence of the terraform binary file instead of the terraform directory. * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor azuread_service_principal data source to conditionally include object_id in locals * Update SDAF version to 3.13.1.0 in ansible-input-api.yaml and version.txt * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines * Refactor echo statements for improved formatting in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh and providers.tf * Refactor echo statements for improved formatting and remove unnecessary output in installer.sh * Refactor installer.sh to fix path issue and pass parameters correctly * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include deployer subscription parameter and persist parameters * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call * Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call and handle storage account authentication * Refactor deploy_controlplane.sh to remove unnecessary echo statement * Refactor deploy_controlplane.sh to remove unnecessary echo statements and improve parameter handling * Refactor deploy_controlplane.sh to improve parameter handling * Refactor deploy_controlplane.sh to improve storage account authentication handling * Refactor deploy_controlplane.sh to improve parameter handling and remove unnecessary echo statements * Refactor deploy_utils.sh to fix variable value retrieval from config file * Refactor parameter handling in script_helpers.sh and install_workloadzone.sh * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling in deploy_utils.sh and script_helpers.sh * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to improve parameter handling and region code handling * Refactor install_workloadzone.sh to remove unnecessary code * Refactor echo statements to improve readability and consistency * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to improve parameter handling and region code handling * Refactor installer.sh to remove unnecessary echo statements * Refactor installer.sh to improve parameter handling and region code handling * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition * Keyvault network rules * Refactor key_vault_sap_landscape.tf to include var.enable_firewall_for_keyvaults_and_storage in the default_action condition * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables * Refactor module.tf to include enable_firewall_for_keyvaults_and_storage variable * Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables and remove error file * Add Terraform output detaisl * Refactor Terraform plugin cache directory handling * Refactor Terraform destroy command in remover.sh * Refactor Terraform destroy command in remover.sh * Refactor echo statement in deploy pipeline to include return code from deployment * Refactor echo statement in deploy pipeline to include return code from deployment --------- Co-authored-by: Kimmo Forss <[email protected]> Co-authored-by: hdamecharla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements across different files, focusing on dependency updates, configuration enhancements, and improved logging and validation in deployment scripts.
Dependency Updates:
AzureandMicrosoftpackage versions inWebapp/SDAF/SDAFWebApp.csprojto ensure compatibility and leverage new features.Configuration Enhancements:
README.mdto reflect the project's security posture.SDAF_Versionindeploy/ansible/vars/ansible-input-api.yamlanddeploy/configs/version.txtto3.13.1.0. [1] [2]Deployment Script Improvements:
pipelinesto ensure critical environment variables are defined and correctly set.Ansible Role Adjustments:
deploy/ansible/roles-os/1.1-swap/defaults/main.yamlto support Oracle Linux and standardized distribution identification.deploy/ansible/roles-os/1.1-swap/tasks/main.yamlto use the newdistribution_idvariable.## ProblemSolution
Tests
Notes