Bring in Experimental fixes #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 1, 2024 14:20
…based on var.database.scale_out
…econdary_instance_name
…OMPUTERNAME, ANYDB_SECONDARY_DNSNAME, and ANYDB_VMNAME
…mprove efficiency
…mprove efficiency
Install unar package on RHEL for extracting exe archives
…s to use "root" instead of "{{ sid_to_be_deployed.sid | lower }}adm"
…m storage accounts
…na_use_master_password is 'n'
…r clustering based on OS in VM
…_tasks' instead of 'include_tasks' for clustering based on OS in VM
…_tasks' instead of 'include_tasks' for clustering based on OS in VM
…_tasks' instead of 'include_tasks' for starting HANA Database
…_tasks' instead of 'include_tasks' for starting HANA Database
|
Refactor Ansible playbooks and configurations
|
SteffenBoThomsen
pushed a commit
to SteffenBoThomsen/sap-automation
that referenced
this pull request
Nov 11, 2024
* Refactor hana_shared_afs_path output to conditionally include values based on var.database.scale_out
* Add the ability to control access key based access to storage accounts
* Web App SAS updates
* Refactor CustomValidators.cs to handle null values in IsValid method
* check string length
* Refactor CustomValidators.cs to handle null values in IsValid method
* Refactor playbook_04_00_00_db_install.yaml to handle null values in secondary_instance_name
* Refactor Azure DevOps project configuration
* Refactor site.js to handle additional storage and network options
* Refactor storage_accounts.tf to conditionally count private endpoint connections
* Refactor sap_namegenerator/output.tf to handle null values in ANYDB_COMPUTERNAME, ANYDB_SECONDARY_DNSNAME, and ANYDB_VMNAME
* Cluster validation logic
* Refactor 5.6 SCS/ERS validation playbook to improve efficiency and readability
* Refactor 5.6 SCS/ERS validation playbook to set sapcontrol path and improve efficiency
* remove the unar package
* Refactor 5.6 SCS/ERS validation playbook to set sapcontrol path and improve efficiency
* Refactor repository vars to remove epel repo for all Red Hat versions
Install unar package on RHEL for extracting exe archives
* Refactor 1.1-swap playbook to use dnf module for updating WALinuxAgent package
* allow_world_readable_tmpfiles for find
* Refactor become_user in DBLoad, PAS Install, and APP Install playbooks to use "root" instead of "{{ sid_to_be_deployed.sid | lower }}adm"
* add Environment variable to allow for silent installations
* Add the ability to set the shared access key access for the sap system storage accounts
* Add 'resource-agents-cloud' package for db2
* Refactor OS image configuration in sap_system/transform.tf
* Refactor HANA_2_00_install.rsp template to fix use_master_password formatting
* Refactor HANA_2_00_install.rsp template to fix password_copy formatting
* Refactor cluster stabilization check for RHEL 8.x and 9.x
* Refactor HANA_2_00_install.rsp template to omit password_copy when hana_use_master_password is 'n'
* Refactor HANA_2_00_install.rsp template to remove password_copy and fix formatting
* Refactor cluster stabilization check for RHEL 8.x and 9.x
* Refactor HANA_2_00_install.rsp template to fix password_copy formatting
* Refactor DB2 cluster tasks for RHEL 8.x and 9.x
* Refactor cluster stabilization check for RHEL 8.x and 9.x
* Refactor cluster stabilization check for RHEL 8.x and 9.x
* Refactor cluster stabilization check for RHEL 8.x and 9.x
* Refactor allow_world_readable_tmpfiles formatting in HANA installation role
* Update azuread provider version to >=3.0 in sap_deployer, sap_library, sap_landscape, sap_library, and sap_system providers.tf files
* Fix the spacing in the ansible role for the SAP 5.2 PAS install
* Refactor spacing in HANA installation role and cluster stabilization check for RHEL 8.x and 9.x
* Refactor password_copy logic in HANA installation role
* Refactor password_copy logic in HANA installation role
* Refactor password_copy logic in HANA installation role
* Refactor password_copy logic in HANA installation role
* Refactor password handling in HANA installation role
* Refactor password handling in HANA installation role
* Refactor password handling and hdbuserstore path in HANA installation role
* Refactor password handling and hdbuserstore path in HANA installation role
* Refactor password handling in HANA installation role
* Refactor ownership in PAS installation role
* Refactor PAS installation role to remove unnecessary debug message
* Refactor become_user in PAS installation role to use lowercase SID adm user
* Refactor become_user in PAS installation role to use root user
* Refactor HANA installation role to include required packages
* Refactor tfvar_variables.tf to include shared access key enabled variables
* Web App updates for shared access keys
* Add tier info for packages task
* Enable world-readable temporary files in ansible.cfg
* add the missing quotes
* Refactor SAP OS configuration playbook to include directory permissions task
* Refactor SAP OS configuration playbook to include directory permissions task
* Add 'resource-agents-sap-hana' to os-packages.yaml
* Refactor SAP OS configuration playbook to include directory permissions task
* Refactor playbook to use 'import_tasks' instead of 'include_tasks' for clustering based on OS in VM
* chore: update ansible.cfg log path to /var/tmp/ansible.log
* Refactor clustering tasks in HANADB Pacemaker playbook
* Refactor clustering tasks in HANADB Pacemaker playbook
* Refactor clustering tasks in HANADB Pacemaker playbook to use 'import_tasks' instead of 'include_tasks' for clustering based on OS in VM
* Refactor clustering tasks in HANADB Pacemaker playbook to use 'import_tasks' instead of 'include_tasks' for clustering based on OS in VM
* Refactor clustering tasks in HANADB Pacemaker playbook to use 'import_tasks' instead of 'include_tasks' for starting HANA Database
* Refactor clustering tasks in HANADB Pacemaker playbook to use 'import_tasks' instead of 'include_tasks' for starting HANA Database
* Remove the include tasks
* Linting
---------
Co-authored-by: Kimmo Forss <[email protected]>
Co-authored-by: hdamecharla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and bug fixes across multiple files, focusing on validation improvements, new configuration options, and updates to Ansible playbooks.
Validation Improvements:
Webapp/SDAF/Models/CustomValidators.cs: EnhancedPrivateEndpointIdValidatorandStorageAccountIdValidatorto handle arrays and null values more robustly.New Configuration Options:
Webapp/SDAF/Models/LandscapeModel.csandWebapp/SDAF/Models/SystemModel.cs: Added new configuration optionsshared_access_key_enabledandshared_access_key_enabled_nfs. [1] [2]Webapp/SDAF/ParameterDetails/LandscapeDetails.jsonandWebapp/SDAF/ParameterDetails/SystemDetails.json: Updated JSON files to include the new configuration options. [1] [2]Webapp/SDAF/ParameterDetails/LandscapeTemplate.txtandWebapp/SDAF/ParameterDetails/SystemTemplate.txt: Updated templates to reflect the new configuration options. [1] [2]Ansible Playbook Updates:
deploy/ansible/playbook_02_os_sap_specific_config.yaml: Reordered tasks to improve the execution sequence. [1] [2]deploy/ansible/playbook_04_00_00_db_install.yaml: Added condition fordatabase_scale_outin the database installation playbook. [1] [2]deploy/ansible/roles-db/4.0.0-hdb-install/tasks/main.yamlanddeploy/ansible/roles-db/4.0.3-hdb-install-scaleout/tasks/main.yaml: Simplified password handling by removing the master password option. [1] [2]deploy/ansible/roles-db/4.0.0-hdb-install/templates/HANA_2_00_install.rspanddeploy/ansible/roles-db/4.0.3-hdb-install-scaleout/templates/HANA_2_00_install_scaleout.rsp: Updated templates to align with the new password handling logic. [1] [2] [3] [4] [5] [6] [7] [8]Miscellaneous Updates:
Webapp/SDAF/SDAFWebApp.csproj: UpdatedNuGet.Packagingpackage version from6.11.0to6.11.1.Webapp/SDAF/wwwroot/js/site.js: Added new IDs to various JavaScript functions for better handling of network and storage configurations. [1] [2] [3] [4] [5]deploy/ansible/ansible.cfg: Changed thelog_pathand addedallow_world_readable_tmpfilesfor better logging and file handling.These changes collectively enhance the robustness, configurability, and maintainability of the codebase.## Problem
Solution
Tests
Notes