Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align custom kernel parameters with extensibility documentation #642

Merged

Conversation

SteffenBoThomsen
Copy link
Contributor

Problem

Currently the extensibility documentation lists that customizations to kernel parameters can be done by

custom_parameters:
  common:
    - { ... }

This is not the case as the code expects them grouped under the distribtuion_id.

Solution

This PR ensures that both common and distribution_id can be utilized to set kernel parameters.
If both common and distribution_id sets the same property, the distribution_id will take precedence.
See the following example:

image

Which results in parameters being set like the following on the os level

image

…://learn.microsoft.com/en-us/azure/sap/automation/extensibility#adding-custom-kernel-parameters-linux

This ensures that `custom_parameters` can be set both by common and distribution_id.

It will weight the setting from distribution_id higher than common by filtering on the unique kernel parameter name.
@SteffenBoThomsen SteffenBoThomsen requested a review from a team as a code owner October 3, 2024 14:04
@SteffenBoThomsen SteffenBoThomsen requested review from ajaygit158 and removed request for a team October 3, 2024 14:04
@devanshjainms
Copy link
Contributor

Thanks for the contribution. @SteffenBoThomsen

@devanshjainms devanshjainms merged commit fee83ea into Azure:experimental Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants