Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RBAC conditions to sub-vending module #3545

Merged
merged 50 commits into from
Oct 22, 2024

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Oct 13, 2024

Description

Added RBAC constrained delegation feature to role assignments

Pipeline Reference

Pipeline
avm.ptn.lz.sub-vending

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

chore: Update telemetry parameter description

fix: Update templateHash in main.json

fix: Update role assignment condition description in subResourceWrapper.bicep

fix: Update enforced location for Synapse Workspace

fix: Fix APIM SKUs deployment logic

feat: Add support for private network to Databricks workspace storage account
chore: Update telemetry parameter description

fix: Update templateHash in main.json

fix: Update role assignment condition description in subResourceWrapper.bicep

fix: Update enforced location for Synapse Workspace

fix: Fix APIM SKUs deployment logic

feat: Add support for private network to Databricks workspace storage account
…d-environment`

feat: Added output `networkInterfaceIds` to `avm/res/network/private-endpoint` module

fix: bump actions/upload-artifact from 4.3.4 to 4.3.5

feat: Update DocumentDB to secrets export spec

feat: Update RBAC schema in `avm/res/container-registry/registry`

feat: Update `avm/res/insights/webtest` module parameters

feat: Add `credential-set` child module to `avm/res/container-registry/registry`

feat: Update rbac schema in API Management

feat: Add output 'fqdn' in MySQL Module - `avm/res/db-for-my-sql/flexible-server`

feat: update RBAC schema in `avm/res/container-registry/registry`
…st.bicep` to use 'srbac' as the value for the 'serviceShort' parameter
…ourceProviderList.ps1` parameters

The `subscriptionId` and `resourceProviders` parameters in the `Register-SubscriptionResourceProviderList.ps1` script have been updated.
The roleAssignments parameter in the sub-vending main.bicep file has been updated to use the roleAssignmentType from the subResourceWrapper module.
… main.json

The property name "_1.roleAssignmentCondtionType" has been updated to "_1.roleAssignmentConditionType" in the sub-vending main.json file.
@sebassem sebassem requested review from a team as code owners October 13, 2024 09:15
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 13, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 13, 2024
@jtracey93 jtracey93 self-assigned this Oct 22, 2024
@jtracey93 jtracey93 self-requested a review October 22, 2024 08:07
Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work @sebassem LGTM

@jtracey93 jtracey93 merged commit 048797b into Azure:main Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants