Fix azure-monitor-opentelemetry-autoconfigure #8445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The azure-monitor-opentelemetry-autoconfigure project should be displayed in the Monitor table of content.
jeanbisutti
requested review from
ronniegeraghty,
mssfang,
mario-guerra and
scottaddie
as code owners
|
cc @srnagar |
ronniegeraghty
requested changes
Jan 24, 2025
| @@ -594,7 +594,7 @@ | |||
| "spring-cloud-azure-stream-binder-test","com.azure.spring","","4.0.0-beta.2","Spring Cloud Azure Stream Binder Test","","NA","NA","NA","","false","","","","","","","","","","","","" | |||
| "azure-container-apps-maven-plugin","com.microsoft.azure","","0.2.0","Unknown Display Name","Unknown Service","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
| "azure-functions-java-library-mysql","com.microsoft.azure.functions","","1.0.1-preview","Unknown Display Name","Unknown Service","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
| "azure-monitor-opentelemetry-autoconfigure","com.azure","","1.0.0-beta.1","Unknown Display Name","Unknown Service","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
| "azure-monitor-opentelemetry-autoconfigure","com.azure","","1.0.0-beta.1","Monitor","monitor","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
There was a problem hiding this comment.
I believe the Service Name for it should be Monitor, capital M.
Also, with the Package Display Name as Monitor as well this will cause to show up on the Docs ToC as:
Monitor
└── Monitor
Is there a more specific name for the Package Display Name. Maybe like OpenTelemetry AutoConfigure
Are there any other public docs for this library/service that might have the proper branding for the library on them?
srnagar
reviewed
Jan 24, 2025
| @@ -594,7 +594,7 @@ | |||
| "spring-cloud-azure-stream-binder-test","com.azure.spring","","4.0.0-beta.2","Spring Cloud Azure Stream Binder Test","","NA","NA","NA","","false","","","","","","","","","","","","" | |||
| "azure-container-apps-maven-plugin","com.microsoft.azure","","0.2.0","Unknown Display Name","Unknown Service","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
| "azure-functions-java-library-mysql","com.microsoft.azure.functions","","1.0.1-preview","Unknown Display Name","Unknown Service","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
| "azure-monitor-opentelemetry-autoconfigure","com.azure","","1.0.0-beta.1","Unknown Display Name","Unknown Service","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
| "azure-monitor-opentelemetry-autoconfigure","com.azure","","1.0.0-beta.1","Monitor","monitor","NA","NA","NA","","false","","","","","","","","","","","","Needs Review" | |||
There was a problem hiding this comment.
nit: It would be good to add this entry alongside the other monitor packages to group them all together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The azure-monitor-opentelemetry-autoconfigure project should be displayed in the Monitor table of content.