net - pullrequest
#47957
net - pullrequest
#47957
Conversation
revert updates to the azurite yml. re-add Install-Azurite. Make the installation part of only the build test stage
scbedd
requested review from
hallipr,
weshaggard,
benbp,
seanmcc-msft,
amnguye,
jaschrep-msft,
schaabs,
tg-msft,
jalauzon-msft,
nickliu-msft and
jsquire
as code owners
| - pwsh: | | ||
| $services = "$(ChangedServices)" -split "," | ||
|
|
||
| foreach ($service in $services) { |
There was a problem hiding this comment.
Can we not use the project override list for this step?
There was a problem hiding this comment.
I think we can. There's another place in the build stage that does this as well.
| @@ -59,7 +59,8 @@ | |||
| "SupportsRecording": true, | |||
| "CollectCoverage": true | |||
| } | |||
| } | |||
| }, | |||
| "AdditionalTestArguments": "/p:UseProjectReferenceToAzureClients=false" | |||
There was a problem hiding this comment.
Did we intentionally want to add this to the include?
There was a problem hiding this comment.
I did. It's so that this value is present on the Include matrix run added to the matrix at the end. I'm just ensuring that the variable is available so that when we attempt to override it in the matrix (remember we re-use the matrix values) it just works.
| @@ -62,6 +62,49 @@ | |||
| <ItemGroup Condition="'$(ProjectListOverrideFile)' != '' "> | |||
| <Track1ProjectsToRemove Include="$(MSBuildThisFileDirectory)..\sdk\*\Microsoft.*.Management.*\**\*.csproj;$(MSBuildThisFileDirectory)..\sdk\*mgmt*\**\*.csproj;$(MSBuildThisFileDirectory)..\sdk\*\Microsoft.Azure.*\**\*.csproj" /> | |||
| <ProjectReference Remove="@(Track1ProjectsToRemove)" /> | |||
| <MgmtExcludePaths Include="$(MSBuildThisFileDirectory)..\sdk\*\Microsoft.*.Management.*\**\*.csproj;$(MSBuildThisFileDirectory)..\sdk\*mgmt*\**\*.csproj" /> | |||
There was a problem hiding this comment.
Does this mean none of these projects will be included in the PR pipeline? Also are these actual mgmt projects or are you just piggy backing on this include?
There was a problem hiding this comment.
Does this mean none of these projects will be included in the PR pipeline? Also are these actual mgmt projects or are you just piggy backing on this include?
I'm keeping these mgmt exclude paths because these exclusions are what are honored by default for most usages of the eng/service proj (targeted at a specific service directory).
There was a problem hiding this comment.
If we need these now I wonder if there is a better way to share them with the list above instead of duplicating.
There was a problem hiding this comment.
Will pick on re-using the item group.
|
|
||
| $setting = $pkgNames -join "," | ||
| Write-Host "Setting ProjectNames to: `n$setting" | ||
| Write-Host "##vso[task.setvariable variable=ProjectNames;]$setting" |
There was a problem hiding this comment.
Is the project names actually interesting for anything? I would expect folks to use the project overrides or just the packageinfos in most places.
There was a problem hiding this comment.
This is a good point. If we don't use it anywhere I'll clean this up.
Project Names is set by the matrix strategy for build-test. We need to keep this around for when a matrix isn't setting ProjectNames variable. (this would be in build/analyze stages).
eng/scripts/Language-Settings.ps1
Outdated
| $DependencyCalculationPackages = @( | ||
| "Azure.Core", | ||
| "Azure.Identity"#, | ||
| # "Azure.ResourceManager" temporarily removed until we can figure out why it's not working correctly on the build machine. it works locally |
There was a problem hiding this comment.
Going to fix this in next commit as well.
…t packages when assembling docs
This PR...
net - pullrequestbuild.Azure.CoreorAzure.ResourceManagerare present in the set of packages that have been changed, their dependencies are also discovered and distributed sparsely to test runs. This completely replaces the staticAdditionalDependencyleg that currently exists only onnet - coreandnet - resourcemanager. It utilizes exactly the same dependency discovery that original leg utilized. (eng/service.projProjectDependsOntarget)Azure.Core/Azure.ResourceManager. That can be adjusted.Todo:
resourcemanagercore