Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFS over REST #32496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NFS over REST #32496

wants to merge 1 commit into from

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Jan 10, 2025

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jan 10, 2025
@@ -641,6 +698,7 @@ export interface FileForceCloseHandlesHeaders {
// @public
export interface FileForceCloseHandlesOptions extends CommonOptions {
abortSignal?: AbortSignalLike;
leaseAccessConditions?: LeaseAccessConditions;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if the header is added correctly. Looks not change in this API version.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/storage-file-share

filePermission?: string;
filePermissionFormat?: FilePermissionFormat;
filePermissionKey?: string;
leaseAccessConditions?: LeaseAccessConditions;
metadata?: Metadata;
nfsProperties?: FilePosixProperties;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.net SDK might have changed the property name, please check .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants