Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-AzStorageSyncServer: Fix string comparison and add scenario test #27041

Draft
wants to merge 7 commits into
base: shared/StorageSync
Choose a base branch
from

Conversation

stefong99
Copy link

Description

This PR fixes a missing case insensitive string comparison and also adds a scenario test for the Set-AzStorageSyncServer commandlet.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

dantedallag and others added 6 commits January 17, 2025 15:51
* Deprecate the Blueprints cmdlets.

* Update Blueprint cmdlets deprecation messages and changelog.

* Changing the deprecation message.

* Update deprecation version.

* Update blueprint version deprecation.

---------

Co-authored-by: Dante DG <test>
* Move DataProtection to main

* Update ChangeLog.md

---------

Co-authored-by: Yan Xu <[email protected]>
* generate Synapse SDK by autorest csharp

* batch sql gen 3 20200401preview

* generate Synapse by autorest powershell and fix naming

* Update ChangeLog.md

* fix naming

* Update README.md

* add batch tag

* delete KustoPool.json

* Update README.md

* update test

* Update restore pool example by Q&A 2047354

* Credential Scanner Error fix

* undo skip test case

* generate Synapse SDK by autorest csharp

* batch sql gen 3 20200401preview

* generate Synapse by autorest powershell and fix naming

* Update ChangeLog.md

* fix naming

* Update README.md

* add batch tag

* delete KustoPool.json

* Update README.md

* update test

* Update restore pool example by Q&A 2047354

* Credential Scanner Error fix

* undo skip test case

* Update ChangeLog.md

* Revert "Merge branch 'joyer/Synapse-sdk-migration' of https://github.com/Azure/azure-powershell into joyer/Synapse-sdk-migration"

This reverts commit 89d95f2, reversing
changes made to 1cdf198.

* Update WorkspaceTests.ps1

* use common function to wait

* format fix

* format fix 2
* Move EventHub to main

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: Yan Xu <[email protected]>
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@stefong99 stefong99 marked this pull request as draft January 23, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants