Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http scheme for AsgiRequest #198

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Conversation

hallvictoria
Copy link
Contributor

Fixes #1185

AsgiRequest scheme is currently hard-coded to https. The scheme should allow both http or https, depending on the incoming request. This change uses urllib.parse.urlparse to handle both types.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ca53b3) 92.97% compared to head (357a4ba) 92.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #198      +/-   ##
==========================================
- Coverage   92.97%   92.91%   -0.06%     
==========================================
  Files          56       56              
  Lines        3187     3190       +3     
  Branches      649      649              
==========================================
+ Hits         2963     2964       +1     
- Misses        137      138       +1     
- Partials       87       88       +1     
Flag Coverage Δ
unittests 92.88% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review December 18, 2023 20:52
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (b85eb7a) to head (357a4ba).
Report is 1 commits behind head on dev.

❗ Current head 357a4ba differs from pull request most recent head 2073418. Consider uploading reports for the commit 2073418 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #198      +/-   ##
==========================================
- Coverage   93.10%   92.91%   -0.19%     
==========================================
  Files          56       56              
  Lines        3247     3190      -57     
  Branches      666      649      -17     
==========================================
- Hits         3023     2964      -59     
- Misses        137      138       +1     
- Partials       87       88       +1     
Flag Coverage Δ
unittests 92.88% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria merged commit c7c31dd into dev Apr 30, 2024
13 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/asgireq-scheme branch April 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AsgiRequest hard codes scheme as 'https' in scope
3 participants