-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow http scheme for AsgiRequest #198
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #198 +/- ##
==========================================
- Coverage 92.97% 92.91% -0.06%
==========================================
Files 56 56
Lines 3187 3190 +3
Branches 649 649
==========================================
+ Hits 2963 2964 +1
- Misses 137 138 +1
- Partials 87 88 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #198 +/- ##
==========================================
- Coverage 93.10% 92.91% -0.19%
==========================================
Files 56 56
Lines 3247 3190 -57
Branches 666 649 -17
==========================================
- Hits 3023 2964 -59
- Misses 137 138 +1
- Partials 87 88 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #1185
AsgiRequest scheme is currently hard-coded to https. The scheme should allow both http or https, depending on the incoming request. This change uses
urllib.parse.urlparse
to handle both types.