Heiarchical Partition Keys: Fixes bug for ReadMany where None Partition does not return results
#4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
| @@ -304,6 +304,15 @@ private QueryDefinition CreateReadManyQueryDefinitionForOther(List<(string, Part | |||
| } | |||
| for (int j = 0; j < this.partitionKeySelectors.Count; j++) | |||
| { | |||
| if (pkValues[j] == Undefined.Value) | |||
There was a problem hiding this comment.
In-general ReadMany is for many point operation reads => each partition-key should be complete/full.
Hierarchical partitions: ReadMany as name might get mis-mapped for HierarchicalParittioning, isn't the ideal solution to use regular query instead?
| if (pkValues[j] == Undefined.Value) | ||
| { | ||
| queryStringBuilder.Append(" AND "); | ||
| queryStringBuilder.Append("IS_DEFINED(c"); |
There was a problem hiding this comment.
Clarification: Create will not work if any of the partition-keys are not defined right?
Can we please check this with query team.
There was a problem hiding this comment.
Can this clause it-self be excluded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
There is currently a bug in the
ReadManymethod where it does not return results for partial hierarchical partition keys when a partition key with aNoneType is set.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4946