HA: Fixes CrossRegion retry also on RequestTimeout from addressRefresh [DO-NOT-MERGE] #4962
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirankumarkolli
requested review from
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
kirankumarkolli
changed the title
kirankumarkolli
commented
Jan 11, 2025
| if (statusCode == HttpStatusCode.ServiceUnavailable) | ||
| // 408 retry: limit to document resource-type? | ||
| if (statusCode == HttpStatusCode.ServiceUnavailable | ||
| || statusCode == HttpStatusCode.RequestTimeout) |
There was a problem hiding this comment.
User cancellationTokens might get impacted as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
ClientRetryPolicy expects that RequestTimeouts gets converted to 503 by HA stack.
In cases of AddressRefresh calls the AddressRefresh calls timeouts are not converted to 503 but original TaskCancellationException is thrown.
Changes to HA stack will have higher impact radius, instead a generic is retry is added now to the ClientRetryPolicy.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber