Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThroughputBucketing: Fixes ThroughputBucket to always be internal #4960

Merged

Conversation

Achint-Agrawal
Copy link
Contributor

@Achint-Agrawal Achint-Agrawal commented Jan 10, 2025

Pull Request Template

Description

Throughput bucketing is not currently released publicly. This PR makes ThroughputBucket internal. Will expose it in preview SDK once throughput bucketing is deployed in prod.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@Achint-Agrawal Achint-Agrawal changed the title Making ThroughputBucket internal Fixes: Making ThroughputBucket internal Jan 10, 2025
@Achint-Agrawal Achint-Agrawal changed the title Fixes: Making ThroughputBucket internal ThroughputBucketing: Fixes ThroughputBucket to always be internal Jan 10, 2025
@Achint-Agrawal Achint-Agrawal requested a review from a team as a code owner January 10, 2025 19:20
@kirankumarkolli kirankumarkolli merged commit 48bc504 into master Jan 13, 2025
27 checks passed
@kirankumarkolli kirankumarkolli deleted the users/acagrawal/throughputBucketing/addRequestOptions branch January 13, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants