-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThroughputBucketing: Fixes ThroughputBucket to always be internal #4960
Merged
kirankumarkolli
merged 17 commits into
master
from
users/acagrawal/throughputBucketing/addRequestOptions
Jan 13, 2025
Merged
ThroughputBucketing: Fixes ThroughputBucket to always be internal #4960
kirankumarkolli
merged 17 commits into
master
from
users/acagrawal/throughputBucketing/addRequestOptions
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Achint-Agrawal
requested review from
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
January 10, 2025 18:47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Achint-Agrawal
changed the title
Making ThroughputBucket internal
Fixes: Making ThroughputBucket internal
Jan 10, 2025
Achint-Agrawal
changed the title
Fixes: Making ThroughputBucket internal
ThroughputBucketing: Fixes ThroughputBucket to always be internal
Jan 10, 2025
kirankumarkolli
approved these changes
Jan 10, 2025
Pilchie
approved these changes
Jan 13, 2025
kirankumarkolli
deleted the
users/acagrawal/throughputBucketing/addRequestOptions
branch
January 13, 2025 23:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Throughput bucketing is not currently released publicly. This PR makes ThroughputBucket internal. Will expose it in preview SDK once throughput bucketing is deployed in prod.
Type of change
Please delete options that are not relevant.